Note polling is broken in 8.2.x and master

a527f5c2 introduced a check on note.valid before rendering the note, but Project::NotesController#index never defined this value in the JSON, so notes never rendered.

Fix is incoming.

cc @grzesiek

mentioned in merge request !2084 (merged)

mentioned in issue #3530 (closed)

@grzesiek Not blaming you for this one -- it's unexpected that we have a render_note_json method in the controller and then don't use it for all of our JSON rendering in that controller.

That's just the insanity that is our Notes system!

@rspeicher Well I should have checked it, do you want to me to fix it ?

@grzesiek Already fixed, see mentioned MR.

@rspeicher Easiest fix would be checking if note object contains valid property using The Existential Operator available in CoffeeScript

@rspeicher Thanks!

@rspeicher I will write some tests for note polling then.

@grzesiek awesome that you'll write tests

mentioned in merge request !2086 (merged)

Status changed to closed by merge request !2084 (merged)

mentioned in commit 118d9690

mentioned in commit 9451db38

mentioned in commit 7c14541d

mentioned in commit 4493d3fd

mentioned in commit 1322bd78

mentioned in merge request !14785