Endless redirect for some logins
There is an issue with a situation that causes an endless page redirect.
Reproduce it:
-
Disable the referer header in the browser. No header with this property should be sent by your browser.
-
Open an issue's page in a browser without being logged in. For example, https://gitlab.com/gitlab-org/gitlab-ce/issues/4253 .
-
Click on the sign in button, above the page. The URL https://gitlab.com/users/sign_in?redirect_to_referer=yes should be opened.
-
Type your login and password. The referer header is empty, it does not exist. But Gitlab is trying to redirect to it, without noting this. An endless redirect loop happens here.
This issue should work in all browsers, given the setting I pointed above.