sidebar nav ui bugs
After playing around with the new sidebar nav layout, I found some bugs regarding the ui.
- The border on the content area doesn't reach the bottom of the page when the content isn't long enough
- Could be fixed by setting a border-right on the sidebar-wrapper, instead of border-left on content-wrapper, and change sidebar-wrapper to position: fixed;
- The page is always scrollable for about 48px, because the sidebar wrapper being 100% height, but the navbar taking up 48px above it.
- Could be fixed by setting margin-top: -48px, on the sidebar-wrapper.
- On mobile, some items are not available, because they are off the screen (mostly just the project settings items).
- Could be fixed by making the sidebar-wrapper have position: fixed; overflow-x: hidden, then the nav-sidebar have position: absolute;
Another suggestion:
- Make the navbar have a fixed position at the top of the page.
I already have the fixes for this in my fork, If you want I can create a merge request for it.