Skip to content
Snippets Groups Projects

Fix Unicode 1.1 emojis

Merged username-removed-892863 requested to merge 29557-fix-unicode-1-1 into master

What does this MR do?

  • Adjust font-stack on emojis to only use font-family: "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

When using the full font-stack some the Unicode 1.1 emojis are taken up by fonts closer up the stack and don't represent the emoji well.

font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";
  • On Windows, "Segoe UI" -> "Arial" takes over
  • On mac OS, "Helvetia" -> ".SF NS Display" takes over
mac OS 10.12.3 Windows 10

When using a shorter emoji font-stack, everything seems to be covered well :tada:

font-family: "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";
  • On Windows, "Segoe UI Emoji" takes over
  • On mac OS, "Apply Color Emoji" takes over
mac OS 10.12.3 Windows 10

Screenshots from Emoji Unicode by Version demo, https://jsfiddle.net/MadLittleMods/xw9moyfw/

@MadLittleMods, https://gitlab.com/gitlab-org/gitlab-ce/issues/29557#note_25544684

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #29557 (closed)


cc @lbennett

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading