Skip to content
Snippets Groups Projects

Spam check only when Snippet / Issue "title" or "description" are changed

Merged Oswaldo Ferreir requested to merge 29483-spam-check-only-title-and-description into master

With this MR we're narrowing when the spam check is triggered and properly presenting the errors when trying to update the description with an AJAX call (i.e. task lists).

EE Backport gitlab-ee!1479

See #29483 (moved), #29645 (closed) for more info.

Screenshots (if relevant)

Screen_Shot_2017-03-20_at_11.46.58_PM

Closes #29483 (moved), #29645 (closed)

Merge request reports

Pipeline #7157069 passed

Pipeline passed for d730b69e on 29483-spam-check-only-title-and-description

Test coverage 93.32% (0.00%) from 1 job

Merged by username-removed-443319username-removed-443319 8 years ago (Mar 22, 2017 11:54am UTC)

Loading

Pipeline #7172613 failed

Pipeline failed for 85ffd85a on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jarka Kadlecova
  • Thanks @oswaldo . I just have few comments.

  • assigned to @oswaldo

  • Oswaldo Ferreir added 2 commits

    added 2 commits

    • 86ef67ee - Present ajax call errors when failing to update an Issue
    • d730b69e - Spam check only when spammable attributes have changed

    Compare with previous version

  • Thanks @jarka, I've addressed your comments :smile:

  • Oswaldo Ferreir changed title from Spam check only when "title" or "description" are changed to Spam check only when Snippet / Issue "title" or "description" are changed

    changed title from Spam check only when "title" or "description" are changed to Spam check only when Snippet / Issue "title" or "description" are changed

  • @smcgivern Could you pick this one to have a look?

  • @jarka should have another look first :wink:

  • Jarka Kadlecova resolved all discussions

    resolved all discussions

  • thanks, seems ok to me

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading