Skip to content
Snippets Groups Projects

Show CI status as Favicon on Pipelines, Job and MR pages

Merged kushalpandya requested to merge 12818-ci-status-as-favicon into master
All threads resolved!

What does this MR do?

Shows dynamic CI status as Page Favicon for Pipelines, Job and MR pages. See #12818 (closed)

Are there points in the code the reviewer needs to double check?

This MR is entirely dependent on !9561 (merged), DO NOT merge this before !9561 (merged). Once the original MR is merged, I'll rebase related branch and update this MR. !9561 (merged) is merged, we're good to go for this now.

Why was this MR needed?

See #12818 (closed)

Screenshots

MR page

MR_Page

Pipeline Index Page

Pipeline_Index

Build real-time update (ignore colors in this GIF)

Peek_2017-02-06_21-00

Does this MR meet the acceptance criteria?

Related EE Merge Request

https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1549

What are the relevant issue numbers?

Closes #12818 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • kushalpandya added 148 commits

    added 148 commits

    • cd1208c1...ac67ce85 - 138 commits from branch master
    • 19b93073 - CI Status Favicon
    • 2ad298ba - Update Favicon to reflect job status for CI
    • 7fc872d6 - Initialize Pipelines index with status URL
    • e87c3987 - Update Favicon to reflect pipeline status
    • 0bd95d31 - Set ID to query and update favicon
    • bfb49713 - Add utility methods to update Favicon for CI status
    • dbe24315 - Karma: Update tests
    • 7863483a - Add changelog entry
    • c368aafb - Pass pipeline_status path from controller to widget init
    • e4178618 - Update to use pipeline status URL from widget opts

    Compare with previous version

  • kushalpandya resolved all discussions

    resolved all discussions

  • kushalpandya marked the task Changelog entry added, if necessary as completed

    marked the task Changelog entry added, if necessary as completed

  • kushalpandya marked the task API support added as completed

    marked the task API support added as completed

  • kushalpandya marked the task Added for this feature/bug as completed

    marked the task Added for this feature/bug as completed

  • marked the task Squashed related commits together as completed

  • kushalpandya unmarked as a Work In Progress

    unmarked as a Work In Progress

  • kushalpandya added 41 commits

    added 41 commits

    • e4178618...91f43587 - 31 commits from branch master
    • f865609a - CI Status Favicon
    • 16d38ec1 - Update Favicon to reflect job status for CI
    • b1b69afe - Initialize Pipelines index with status URL
    • 49752a57 - Update Favicon to reflect pipeline status
    • 4ba61dde - Set ID to query and update favicon
    • a47b0ce7 - Add utility methods to update Favicon for CI status
    • d915173d - Karma: Update tests
    • 5771303f - Add changelog entry
    • cd8261d4 - Pass pipeline_status path from controller to widget init
    • 72d1ede4 - Update to use pipeline status URL from widget opts

    Compare with previous version

  • kushalpandya added 61 commits

    added 61 commits

    • 72d1ede4...bcb0a554 - 51 commits from branch master
    • f782c52c - CI Status Favicon
    • 77192e65 - Update Favicon to reflect job status for CI
    • 5e137b4c - Initialize Pipelines index with status URL
    • 165508de - Update Favicon to reflect pipeline status
    • cb0cfcee - Set ID to query and update favicon
    • 83a18303 - Add utility methods to update Favicon for CI status
    • a4149933 - Karma: Update tests
    • d845f4be - Add changelog entry
    • 8369da5c - Pass pipeline_status path from controller to widget init
    • cceaa43e - Update to use pipeline status URL from widget opts

    Compare with previous version

  • Author Maintainer

    @alfredo1 Can you review? although one Spinach job is failing, but that's due to https://gitlab.com/gitlab-org/gitlab-ce/issues/30236.

  • kushalpandya assigned to @alfredo1

    assigned to @alfredo1

  • kushalpandya added 46 commits

    added 46 commits

    • cceaa43e...e7e93072 - 36 commits from branch master
    • 409e07b5 - CI Status Favicon
    • 418881fa - Update Favicon to reflect job status for CI
    • 8228fffa - Initialize Pipelines index with status URL
    • d43713a8 - Update Favicon to reflect pipeline status
    • 3983db4f - Set ID to query and update favicon
    • 5863a76a - Add utility methods to update Favicon for CI status
    • 06e7bd39 - Karma: Update tests
    • 43ef87a5 - Add changelog entry
    • 0d73560c - Pass pipeline_status path from controller to widget init
    • 50f7fb96 - Update to use pipeline status URL from widget opts

    Compare with previous version

  • kushalpandya marked the task All builds are passing as completed

    marked the task All builds are passing as completed

  • @kushalpandya looks like the colors for each status have changed slightly

    Screen_Shot_2017-04-04_at_11.38.21_PM

    Can you check please?

  • Author Maintainer

    @dimitrieh can you verify color of icon for running status? I guess this is due to recent changes in color scheme.

  • kushalpandya added 2 commits

    added 2 commits

    • 498cd6b6 - Remove unnecessary const, rename method to setCiStatusFavicon
    • 3ea4cdcb - Method rename to setCiStatusFavicon

    Compare with previous version

  • kushalpandya resolved all discussions

    resolved all discussions

  • @pedroms this is correct, isn't it? :)

  • @dimitrieh @kushalpandya yup, the color is correct and up-to-date 🙂

  • Author Maintainer

    Thanks a lot @dimitrieh @pedroms! 😃

    @alfredo1 I've updated the MR (of both CE & EE) with changes as per your feedback, please take a look. 🙂

  • kushalpandya assigned to @alfredo1

    assigned to @alfredo1

  • merged

  • Jacob Schatz mentioned in commit 9c2979ec

    mentioned in commit 9c2979ec

  • mentioned in issue #30895 (closed)

  • Please register or sign in to reply
    Loading