Show CI status as Favicon on Pipelines, Job and MR pages
What does this MR do?
Shows dynamic CI status as Page Favicon for Pipelines, Job and MR pages. See #12818 (closed)
Are there points in the code the reviewer needs to double check?
This MR is entirely dependent on !9561 (merged), DO NOT merge this before !9561 (merged). Once the original MR is merged, I'll rebase related branch and update this MR. !9561 (merged) is merged, we're good to go for this now.
Why was this MR needed?
See #12818 (closed)
Screenshots
MR page
Pipeline Index Page
Build real-time update (ignore colors in this GIF)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary [ ] Documentation created/updated-
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
Related EE Merge Request
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1549
What are the relevant issue numbers?
Closes #12818 (closed)
Merge request reports
Activity
mentioned in merge request !8878 (closed)
marked the task Conform by the merge request performance guides as completed
marked the task Conform by the style guides as completed
added 276 commits
-
8460e6f8...40e3a701 - 268 commits from branch
master
- 5f891464 - CI Status Favicon
- 5b034a70 - Update Favicon to reflect job status for CI
- 27730096 - Initialize Pipelines index with status URL
- a006ecb6 - Update Favicon to reflect pipeline status
- 5a4e5dfd - Set ID to query and update favicon
- 1f6a165c - Add utility methods to update Favicon for CI status
- e1457b12 - Karma: Update tests
- 45b5310a - Add changelog entry
Toggle commit list-
8460e6f8...40e3a701 - 268 commits from branch
added 45 commits
-
45b5310a...d4c99f64 - 37 commits from branch
master
- 5f95590e - CI Status Favicon
- 3aa78e0b - Update Favicon to reflect job status for CI
- a036e128 - Initialize Pipelines index with status URL
- c6632292 - Update Favicon to reflect pipeline status
- 80724195 - Set ID to query and update favicon
- 889e0ff5 - Add utility methods to update Favicon for CI status
- 5d489314 - Karma: Update tests
- cd1208c1 - Add changelog entry
Toggle commit list-
45b5310a...d4c99f64 - 37 commits from branch
- Resolved by kushalpandya
added 148 commits
-
cd1208c1...ac67ce85 - 138 commits from branch
master
- 19b93073 - CI Status Favicon
- 2ad298ba - Update Favicon to reflect job status for CI
- 7fc872d6 - Initialize Pipelines index with status URL
- e87c3987 - Update Favicon to reflect pipeline status
- 0bd95d31 - Set ID to query and update favicon
- bfb49713 - Add utility methods to update Favicon for CI status
- dbe24315 - Karma: Update tests
- 7863483a - Add changelog entry
-
c368aafb - Pass
pipeline_status
path from controller to widget init - e4178618 - Update to use pipeline status URL from widget opts
Toggle commit list-
cd1208c1...ac67ce85 - 138 commits from branch
marked the task Changelog entry added, if necessary as completed
marked the task Squashed related commits together as completed
added 41 commits
-
e4178618...91f43587 - 31 commits from branch
master
- f865609a - CI Status Favicon
- 16d38ec1 - Update Favicon to reflect job status for CI
- b1b69afe - Initialize Pipelines index with status URL
- 49752a57 - Update Favicon to reflect pipeline status
- 4ba61dde - Set ID to query and update favicon
- a47b0ce7 - Add utility methods to update Favicon for CI status
- d915173d - Karma: Update tests
- 5771303f - Add changelog entry
-
cd8261d4 - Pass
pipeline_status
path from controller to widget init - 72d1ede4 - Update to use pipeline status URL from widget opts
Toggle commit list-
e4178618...91f43587 - 31 commits from branch
added 61 commits
-
72d1ede4...bcb0a554 - 51 commits from branch
master
- f782c52c - CI Status Favicon
- 77192e65 - Update Favicon to reflect job status for CI
- 5e137b4c - Initialize Pipelines index with status URL
- 165508de - Update Favicon to reflect pipeline status
- cb0cfcee - Set ID to query and update favicon
- 83a18303 - Add utility methods to update Favicon for CI status
- a4149933 - Karma: Update tests
- d845f4be - Add changelog entry
-
8369da5c - Pass
pipeline_status
path from controller to widget init - cceaa43e - Update to use pipeline status URL from widget opts
Toggle commit list-
72d1ede4...bcb0a554 - 51 commits from branch
@alfredo1 Can you review? although one Spinach job is failing, but that's due to https://gitlab.com/gitlab-org/gitlab-ce/issues/30236.
added 46 commits
-
cceaa43e...e7e93072 - 36 commits from branch
master
- 409e07b5 - CI Status Favicon
- 418881fa - Update Favicon to reflect job status for CI
- 8228fffa - Initialize Pipelines index with status URL
- d43713a8 - Update Favicon to reflect pipeline status
- 3983db4f - Set ID to query and update favicon
- 5863a76a - Add utility methods to update Favicon for CI status
- 06e7bd39 - Karma: Update tests
- 43ef87a5 - Add changelog entry
-
0d73560c - Pass
pipeline_status
path from controller to widget init - 50f7fb96 - Update to use pipeline status URL from widget opts
Toggle commit list-
cceaa43e...e7e93072 - 36 commits from branch
- Resolved by kushalpandya
- Resolved by kushalpandya
assigned to @kushalpandya
@dimitrieh can you verify color of icon for running status? I guess this is due to recent changes in color scheme.
@pedroms this is correct, isn't it? :)
@dimitrieh @kushalpandya yup, the color is correct and up-to-date
🙂 Thanks a lot @dimitrieh @pedroms!
😃
@alfredo1 I've updated the MR (of both CE & EE) with changes as per your feedback, please take a look.🙂 mentioned in commit 9c2979ec
mentioned in issue #30895 (closed)