don't require no_root_squash on NFS, only recommend

What does this MR do?

I don't think no_root_squash is required anymore based on https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/689 and https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/doc/settings/configuration.md#disable-storage-directories-management specifically:

Some types of mounts won't allow automatic creation of directories by root user (default user for initial setup), eg. NFS with root_squash enabled on the share. To work around this the omnibus-gitlab package will attempt to create these directories using the directory's owner user.

/cc @marin @dblessing @twk3

Also posted a related UID and GID question at https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2138 that would love your feedback on.

added ~164274 ~15078 labels

I agree this is a recommendation at this point. A strong recommendation, as while we are setup to create all the required folders etc with root_squash in omnibus, we can never change their owner from omnibus, so there is additional maintenance required on some upgrades for root_squash.

This LGTM

Will omnibus properly tell the user when and how to change ownership as needed?

We currently use 'root_squash' today, as much as we shouldn't.

added 1571 commits

• 47c1411f...7629c9ec - 1570 commits from branch gitlab-org:master
• d7a17107 - don't require no_root_squash on NFS only recommend

Compare with previous version

This is ready for merge.

changed milestone to %9.2

assigned to @axil

approved this merge request

Thanks Ben :)

merged

mentioned in commit c6716908