don't require no_root_squash on NFS, only recommend
What does this MR do?
I don't think no_root_squash
is required anymore based on https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/689 and https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/doc/settings/configuration.md#disable-storage-directories-management specifically:
Some types of mounts won't allow automatic creation of directories by root user (default user for initial setup), eg. NFS with
root_squash
enabled on the share. To work around this the omnibus-gitlab package will attempt to create these directories using the directory's owner user.