Skip to content
Snippets Groups Projects

Remove spreadString in favor of polyfilled Array.from

Merged username-removed-892863 requested to merge 10120-remove-spread-string-for-array-from into master

What does this MR do?

Remove spreadString in favor of polyfilled Array.from. Array.from is a drop-in replacement.

Are there points in the code the reviewer needs to double check?

We use this to split up astral symbols

// ["🖐", "🏿"]
Array.from('🖐🏿');

I have tested in IE11 which doesn't have any Array.from support natively but the polyfill seems to work great, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from#Browser_compatibility

Why was this MR needed?

No need to have an extra spreadString custom function.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #29794 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading