Skip to content

WIP: Fix intermittent spec failures caused by apostrophes in usernames

What does this MR do?

Fixes a number of intermittent spec failures. Names can have apostrophes in them, which end up being escaped in HTML, so naive string comparisons occasionally break with our factories.

Two approaches: escape the names in the expected value, or parse the actual value with a HTML parser like nokogiri before doing the expectation.

Are there points in the code the reviewer needs to double check?

Solution A or solution B? Currently i'm picking B.

Why was this MR needed?

Intermittent spec failures like https://gitlab.com/nick.thomas/gitlab-ce/builds/13341659

Does this MR meet the acceptance criteria?

Merge request reports