Skip to content
Snippets Groups Projects

Fixes method not replacing URL parameters correctly

Merged Filipa Lacerda requested to merge 30264-fix-vue-pagination into master

What does this MR do?

setParamInURL method was not working as expected since it was only replacing the first number of the parameter value.

If we update a parameter with a number with more than one digit, it would not work properly as we can see in this issue #30264 (closed) The same would happen for parameters with strings instead of numbers.

These problems are now fixed and tests were added to guarantee it won't break again.

This MR:

  • removes the regex part
  • Transforms query string into an object
  • Updates the value
  • Merges it back into a string.

This was introduced in 9.0

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #30264 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading