Something went wrong while fetching the environments for this merge request. Please try again.
Fixes method not replacing URL parameters correctly
What does this MR do?
setParamInURL
method was not working as expected since it was only replacing the first number of the parameter value.
If we update a parameter with a number with more than one digit, it would not work properly as we can see in this issue #30264 (closed) The same would happen for parameters with strings instead of numbers.
These problems are now fixed and tests were added to guarantee it won't break again.
This MR:
- removes the
regex
part - Transforms query string into an object
- Updates the value
- Merges it back into a string.
This was introduced in 9.0
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #30264 (closed)
Merge request reports
Activity
Please register or sign in to reply