Skip to content

WIP: Issuable comment & close consistent behaviour

Phil Hughes requested to merge issuable-close-btn-behaviour into master

What does this MR do?

Previously the behaviour of the comment & close action would rely on the PUT request being slow. If the PUT request was actually faster the comment may never exist.

This changes that by waiting for the comment to be successfully posted before sending the PUT request. This behaviour is also mirrored between both merge requests & issues.

For merge requests, the page gets reloaded as it requires a lot of UI changes that can't be handled by the frontend yet (this should be revisited when merge request widget is realtime).

For issues, the UI gets updated by the frontend. However, the POST & PUT requests still happen in the correct order to make sure that the comment is posted before the issue is closed.

What are the relevant issue numbers?

Closes #30577 (moved)

Merge request reports