Add "engineering" UI for Pipeline Schedule

What does this MR do?

We merged this awesome MR, but it was only backend change. This MR brings very simple engineering UI.

It does expose scheduled triggers only when editing page. It is hidden, because we give us a right to break that in %9.2 when we start working on better UI.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

@dosuken123 I used your changes and updated that on top of yours.

I taken different approach, as I did not like _destroy, it creates a lot of mess, so instead it introduces active: which makes the implementation much simpler.

@ayufan Thank you! I'll take a look soon.

/cc @zj @godfat

mentioned in merge request !10510 (closed)

resolved all discussions

added 3 commits

• 221943f2 - Fix ref reference
• 68d88989 - Update tests to cover trigger schedule
• ba1a75d1 - Update migrations

Compare with previous version

resolved all discussions

resolved all discussions

added 1 commit

• 5888e958 - Update code to remove no longer needed changes

Compare with previous version

resolved all discussions

added 106 commits

• 5888e958...7ccaa27f - 95 commits from branch master
• 2548c155 - Add form for scheduled trigger
• 76c0364c - Use allow_destroy. Remove condtion from form.haml.
• ea8574fd - Add specs in triggers_spec.rb (Halfway)
• 4131ed2b - before_create :set_project. Now TriggerSchedule saves project from parent
• 2f5095c2 - Add def trigger_schedule in Trigger. Use persisted? for checling existance
• fb8c49db - create_params and update_params into trigger_params
• 1ae1d85c - N/A to None. Revert validates from validates_presence_of.
• 03088552 - Fix ref reference
• 21a7aed9 - Update tests to cover trigger schedule
• 7cee650d - Update migrations
• 7461072f - Update code to remove no longer needed changes

Compare with previous version

added 1 commit

• 344001d7 - Simplify if

Compare with previous version

added 106 commits

• 5888e958...7ccaa27f - 95 commits from branch master
• 2548c155 - Add form for scheduled trigger
• 76c0364c - Use allow_destroy. Remove condtion from form.haml.
• ea8574fd - Add specs in triggers_spec.rb (Halfway)
• 4131ed2b - before_create :set_project. Now TriggerSchedule saves project from parent
• 2f5095c2 - Add def trigger_schedule in Trigger. Use persisted? for checling existance
• fb8c49db - create_params and update_params into trigger_params
• 1ae1d85c - N/A to None. Revert validates from validates_presence_of.
• 03088552 - Fix ref reference
• 21a7aed9 - Update tests to cover trigger schedule
• 7cee650d - Update migrations
• 7461072f - Update code to remove no longer needed changes

Compare with previous version

@ayufan @dosuken123 How should we merge the changes? In this merge request we're missing error messages, for example.

@godfat Schedule is only available for existing triggers, when you edit them. So information is properly displayed there.

we're missing error messages

Tecnically, this MR covers error messages. NO need to merge from the previous one.

I tested by hands, though, it's working flawlessly, so far...

@ayufan lol that's a nice trick to workaround that.

In addition, there is a full support for ref combobox...

@dosuken123 I did remove that. As it requires more frontend changes.

@godfat error msg screen shot

@dosuken123 This merge request avoids the problem by not allowing to create a schedule along with a new trigger, which is the issue in the first place XD

How to register a trigger schedule

@godfat Yes, but this is also to not expose it easily, as this is experimental. This was my plan since the beginning :)

btw. this CI/CD settings UI is so terrible :(

assigned to @godfat

How trigger schedule work periodically.

NOTE:

trigger_schedule_worker:
      cron: "* * * * *"

I made trigger_schedule_worker perform every minutes.

@ayufan @godfat I'm not sure who's taking this, but I just have a few questions 🙂

assigned to @ayufan

added 1 commit

• d5201119 - Fix test failures

Compare with previous version

added 1 commit

• aeb1f01f - Fix changelog

Compare with previous version

resolved all discussions

added 1 commit

• 8d3f7979 - Fix changelog

Compare with previous version

resolved all discussions

added 1 commit

• 0872b854 - Another round of code review

Compare with previous version

added 1 commit

• 3ea4a139 - Yet, another errors

Compare with previous version

resolved all discussions

enabled an automatic merge when the pipeline for 3ea4a139 succeeds

added 1 commit

• ed368f8c - Fix spec failure

Compare with previous version

assigned to @smcgivern

@ayufan I checked related specs locally and all passed except the point. Thanks. 🌻

LGTM @ayufan

resolved all discussions

added 1 commit

• 4465411b - Fix last spec failure

Compare with previous version

enabled an automatic merge when the pipeline for 4465411b succeeds

@ayufan Please add ref and active at https://gitlab.com/gitlab-org/gitlab-ce/blob/master/spec/lib/gitlab/import_export/safe_model_attributes.yml#L255.

like

Ci::TriggerSchedule:
- id
- project_id
- trigger_id
- deleted_at
- created_at
- updated_at
- cron
- cron_timezone
- next_run_at
- ref
- active
DeployKey:

Other pipelines seem to be ok. Failures are not concerned with this MR.

@dosuken123 done 🙂

added 1 commit

• 682748e8 - Add ref and active to import/export config

Compare with previous version

enabled an automatic merge when the pipeline for 682748e8 succeeds

https://gitlab.com/gitlab-org/gitlab-ce/builds/13920766 - https://gitlab.com/gitlab-org/gitlab-ce/issues/30627

https://gitlab.com/gitlab-org/gitlab-ce/builds/13920807 - fixed by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10531

canceled the automatic merge

merged

mentioned in commit 3ded903d

mentioned in issue #30440 (closed)

mentioned in merge request !10591 (merged)

Were the docs for this feature properly added?

Here https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10591. It's not still merged yet.

This should be added to https://about.gitlab.com/comparison/gitlab-vs-jenkins.html#dropdown as currently this is a feature Jenkins has and GitLab CI does not. Would be good to highlight that they now both have this feature. Created issue at https://gitlab.com/gitlab-com/www-gitlab-com/issues/1285.

mentioned in issue gitlab-com/www-gitlab-com#1285 (closed)

@bbodenmiller It's nice catch!

mentioned in issue #30892 (closed)

mentioned in issue #30882 (closed)

Hey guys, is it planned to have ability to include variables in scheduled trigger also?

@mente Not yet. In the next release %9.2, scheduled trigger will completely be reborn as Pipeline schedule, however, still it doesn't have the ability to set variables. Probably %9.3 or later.