Skip to content

MR Widget Refactor Part 15

Part 15 of the MR widget refactor work.

Previous MRs, all merged into mr-widget-redesign-review

@oswaldo - working on Pipelines:

This MR's target branch is also mr-widget-redesign-review. We are doing this because of incremental reviews. This can be merged into review branch whenever reviewer thinks it's OK.

Two minor things to consider:

  • After clicking merge, even if we return success status on the merge action, errors may happen while processing the merge on background. When it happens, we update MergeRequest#merge_error, hence we should add a special case (right after checking state == 'merged') looking for merge_error, presenting it on mr_widget_failed_to_merge.js.

  • We should check if a project/namespace was removed and show a (removed):target-branch-name - It was caught by integration tests and currently we're not handling this correctly.

Related with #25424 (closed)

Merge request reports