Skip to content
Snippets Groups Projects

Use avatars instead of icons in activity view

Merged Annabel Gray requested to merge use-avatars-in-activity-view into master
All threads resolved!
  • I originally added the icons for all events, regardless of whether they were in the activity view or the profile view
  • Activity view is harder to read without avatars, so this MR puts them back, while keeping icons in activity view
Before After
Screen_Shot_2017-04-10_at_11.03.41_AM Screen_Shot_2017-04-10_at_11.03.23_AM

EE MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1632

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @jschatz1

  • assigned to @DouweM

  • Douwe Maan
  • Douwe Maan
  • Annabel Gray added 2 commits

    added 2 commits

    • d4c5dc49 - Only show icons on profile page; change to case statement
    • 71b7461f - Reuse system notes helper for profile event icons

    Compare with previous version

  • Annabel Gray resolved all discussions

    resolved all discussions

  • Annabel Gray added 1 commit

    added 1 commit

    • 74609fa1 - Add helper for using avatars vs icons

    Compare with previous version

  • Annabel Gray added 1 commit

    added 1 commit

    • 466ca12e - Add helper for using avatars vs icons

    Compare with previous version

  • Annabel Gray resolved all discussions

    resolved all discussions

  • Edited by Annabel Gray
  • assigned to @DouweM

  • Douwe Maan
  • Douwe Maan
  • @annabeldunstone 2 comments :)

  • Annabel Gray resolved all discussions

    resolved all discussions

  • Annabel Gray added 1 commit

    added 1 commit

    • ec34efdc - Move event icons into events_helper

    Compare with previous version

  • @DouweM moved everything into events_helper. Can you review again?

  • Annabel Gray added 1 commit

    added 1 commit

    • 604d198e - Move event icons into events_helper

    Compare with previous version

  • Annabel Gray added 1 commit

    added 1 commit

    • 8552d120 - Move event icons into events_helper

    Compare with previous version

  • assigned to @DouweM

  • Douwe Maan approved this merge request

    approved this merge request

  • Douwe Maan enabled an automatic merge when the pipeline for 8552d120 succeeds

    enabled an automatic merge when the pipeline for 8552d120 succeeds

  • merged

  • Douwe Maan mentioned in commit 3e19ecae

    mentioned in commit 3e19ecae

  • Picked into 9-1-stable, will go into 9.1.0-rc2

  • Douwe Maan mentioned in commit 2979a84b

    mentioned in commit 2979a84b

  • Please register or sign in to reply
    Loading