Remove IIFEs from files in cycle_analytics_bundle.js (!10613) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Merged username-removed-408881 requested to merge remove-iife-cycle-analytics-bundle into master 7 years ago

All threads resolved!

This MR removes unnecesary IIFEs from files used in cycle_analytics_bundle.js

EE port https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1627

ref: https://gitlab.com/gitlab-org/gitlab-ce/issues/29219

Activity

username-removed-408881 @asumaran · 7 years ago

Author Contributor

@mikegreiling Please review
username-removed-408881 assigned to @mikegreiling 7 years ago

assigned to @mikegreiling
username-removed-408881 @asumaran · 7 years ago

Author Contributor

EE port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1627 which has fully passed tests.

Edited 7 years ago by username-removed-408881
username-removed-408881 @asumaran · 7 years ago

Author Contributor

@mikegreiling Friendly ping for review
username-removed-636429 @mikegreiling · 7 years ago

Maintainer

LGTM thanks @alfredo1!

@filipa can you merge this?
username-removed-636429 assigned to @filipa 7 years ago

assigned to @filipa
Filipa Lacerda @filipa started a thread on the diff 7 years ago

Resolved 7 years ago by Filipa Lacerda
Last reply by Filipa Lacerda 7 years ago

Filipa Lacerda resolved all discussions 7 years ago

resolved all discussions

Filipa Lacerda @filipa · 7 years ago

Maintainer

Thank you @alfredo1 LGTM!

Filipa Lacerda approved this merge request 7 years ago

approved this merge request

Filipa Lacerda merged 7 years ago

merged

Filipa Lacerda mentioned in commit 7 years ago

mentioned in commit 7629c9ec

Please register or sign in to reply