Fix restricted visibility project setting

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/30581

Only shows all the project visibility levels if we are an admin. Otherwise, it will show all visibility levels excluding those that are restricted.

• Changelog entry added, if necessary
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

marked the task Changelog entry added, if necessary as completed

marked the task Added for this feature/bug as completed

marked the task Conform by the merge request performance guides as completed

marked the task Conform by the style guides as completed

@vsizov can you review this one? Thanks!

assigned to @vsizov

LGTM

assigned to @jameslopez

resolved all discussions

added 1 commit

• 3a0df2f3 - revert some space changes

Compare with previous version

@DouweM can you review this? Thanks!

assigned to @DouweM

added 1 commit

• 2cbc3481 - use each_with_object

Compare with previous version

resolved all discussions

@jameslopez Build failures!

assigned to @jameslopez

@jameslopez should this be labelled for 9.1 milestone first?

@twk3 that's right, so we decided to go for https://gitlab.com/gitlab-org/gitlab-ce/issues/24322#note_27253626 looks like

Changing milestone to 9.1, we'll also have to pick it on 9.0 or set the milestone to 9.0 once it's merged and picked into 9.1 stable. /cc @godfat @felipe_artur

changed milestone to %9.1

added 223 commits

• 2cbc3481...eeaeb275 - 220 commits from branch master
• 41f1a7aa - fix restricted visibility project setting
• 05ab1bde - revert some space changes
• 2db62561 - use each_with_object

Compare with previous version

added regression label

marked the checklist item All builds are passing as completed

marked the checklist item Branch has no merge conflicts with master (if it does - rebase it please) as completed

@DouweM builds are passing now

assigned to @DouweM

approved this merge request

merged

mentioned in commit d69deb1d

mentioned in issue #31059 (closed)

Picked into 9-1-stable, will go into 9.1.0-rc4

changed milestone to %9.0

mentioned in commit 74d6c203

Picked into stable. Will be in 9.0.6.

mentioned in commit a5ffb991