Return nil as coverage instead of a File object

added 1 commit

• 834e1f6d - Return nil as coverage instead of a File object

Compare with previous version

@zj Could you also change at https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/ci/trace/stream.rb#L78, like

matches = line.scan(regex)
next unless matches.is_a?(Array)
next if matches.empty?

Currently, coverage can't be extracted because the first line of stream passes through the check and got an exception undefined method gsub for nil:NilClass at coverage = match.gsub(/\d+(\.\d+)?/).first.

At least I checked the patch could show coverage in my env.

@dosuken123 Regarding https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10633#note_27329799, I've amended it to the sole commit of this MR.

Thanks for the suggestion.

added 1 commit

• 23fbbe0c - Return nil as coverage instead of a File object

Compare with previous version

@zj awesome!

mentioned in issue #30829 (closed)

mentioned in issue #30831 (closed)

added ci-build regression labels

merged

mentioned in commit 9e99436d

mentioned in issue #30875 (closed)

Picked into 9-1-stable, will go into 9.1.0-rc2

mentioned in commit ac2bd99c

mentioned in issue #30968 (closed)