Skip to content

Set user contribution calendar `overflow-x: scroll` more precisely

username-removed-408230 requested to merge user-activity-scroll-bar into master

This MR addresses two problems with the user contribution calendar container element:

  1. The horizontal scroll bar is initialized before it's needed
  2. When the scrollbar is initialized, you can't easily tell it's a scrollbar

I think setting a more precise viewport width to apply overflow-x: scroll addresses both pretty well. Generally it's a good idea to re-use viewport width variables, but IMO the fact that width of the user contribution calendar is hardcoded necessitates hardcoding the scrolling of its parent element.

Before

screenshot-before

After

2017-04-11_16.45.04

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/30738

Merge request reports