Skip to content
Snippets Groups Projects

Improves support for long build traces:

Merged Filipa Lacerda requested to merge 30696-long-build-log-improvement into master
All threads resolved!

What does this MR do?

  • Change LIMIT_SIZE to 500 KiB, 50 seems too small
  • Adds to truncate message a link to raw: raw_namespace_project_build_path(@project.namespace, @project, @build),
  • Shows size in KiB instead of bytes
  • Removes truncated logic - message should be visible every time size is less than the total.
  • Removes transparent background
  • Updates tests

Screenshots

Screen_Shot_2017-04-12_at_15.03.06

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #30696 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @filipa

  • Filipa Lacerda added 106 commits

    added 106 commits

    Compare with previous version

  • Filipa Lacerda resolved all discussions

    resolved all discussions

  • Filipa Lacerda added 1 commit

    added 1 commit

    Compare with previous version

  • Author Maintainer

    @iamphill fixed :white_check_mark: Can you please take another look?

  • Filipa Lacerda
  • assigned to @filipa

  • Filipa Lacerda added 1 commit

    added 1 commit

    • 82bd76b8 - Create utility function to transform bytes into KiB

    Compare with previous version

  • Filipa Lacerda resolved all discussions

    resolved all discussions

  • Author Maintainer

    @iamphill created an utility function to handle bytes to KiB calculation and added tests. Can you please review again?

    Thank you :)

  • @filipa just one question, might simply be nothing. Part from that, looks good! :thumbsup:

  • Filipa Lacerda resolved all discussions

    resolved all discussions

  • Author Maintainer

    @iamphill fixed! Can you review again please?

  • Filipa Lacerda added 1 commit

    added 1 commit

    • 28f245c4 - Remove verification of being a number

    Compare with previous version

  • Phil Hughes approved this merge request

    approved this merge request

  • Phil Hughes enabled an automatic merge when the pipeline for 28f245c4 succeeds

    enabled an automatic merge when the pipeline for 28f245c4 succeeds

  • Author Maintainer

    Ups :see_no_evil: fixed :)

  • Filipa Lacerda added 1 commit

    added 1 commit

    Compare with previous version

  • Author Maintainer

    @iamphill can you set to MWPS again? Sorry! :blush:

  • Phil Hughes approved this merge request

    approved this merge request

  • Phil Hughes enabled an automatic merge when the pipeline for 69b3b2c0 succeeds

    enabled an automatic merge when the pipeline for 69b3b2c0 succeeds

  • Phil Hughes mentioned in commit aecaaa67

    mentioned in commit aecaaa67

  • merged

  • Picked into 9-1-stable, will go into 9.1.0-rc5

  • Phil Hughes mentioned in commit 435e4090

    mentioned in commit 435e4090

  • Please register or sign in to reply
    Loading