Improves support for long build traces:
What does this MR do?
-
Change LIMIT_SIZE
to500 KiB
,50
seems too small -
Adds to truncate message a link to raw
:raw_namespace_project_build_path(@project.namespace, @project, @build)
, -
Shows size in KiB instead of bytes -
Removes truncated logic - message should be visible every time size is less than the total. -
Removes transparent background -
Updates tests
Screenshots
Does this MR meet the acceptance criteria?
- Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #30696 (closed)
Merge request reports
Activity
@ayufan can you take a look at LIMIT_SIZE change? Thank you :)
ee job was failing, here's the ee port https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1642
@iamphill can you please review this one? Thank you!
assigned to @iamphill
@filipa This is great!
assigned to @filipa
@iamphill can you please review this? It has one broken job, but is not related
i'll keep an eye on itassigned to @iamphill
- Resolved by Filipa Lacerda
- Resolved by Filipa Lacerda
assigned to @filipa
added 106 commits
-
c169aa4c...7d7dfee4 - 105 commits from branch
master
- 57720404 - Merge branch 'master' into 30696-long-build-log-improvement
-
c169aa4c...7d7dfee4 - 105 commits from branch
@iamphill fixed
Can you please take another look?- Resolved by Filipa Lacerda
assigned to @iamphill
assigned to @filipa
added 1 commit
- 82bd76b8 - Create utility function to transform bytes into KiB
@iamphill created an utility function to handle bytes to KiB calculation and added tests. Can you please review again?
Thank you :)
assigned to @iamphill
- Resolved by Filipa Lacerda
@filipa just one question, might simply be nothing. Part from that, looks good!
@iamphill fixed! Can you review again please?
enabled an automatic merge when the pipeline for 28f245c4 succeeds
@filipa eslint failure https://gitlab.com/gitlab-org/gitlab-ce/builds/14511126
@iamphill can you set to MWPS again? Sorry!
enabled an automatic merge when the pipeline for 69b3b2c0 succeeds
mentioned in commit aecaaa67
mentioned in commit 435e4090