Skip to content
Snippets Groups Projects

Fix registry for projects with uppercases in path

Merged Grzegorz Bizon requested to merge fix/gb/fix-registry-for-uppercased-project-paths into master
All threads resolved!

What does this MR do?

This MR fixes container registry for projects that do have uppercase letter in project's path.

We recently added a regular expression which purpose is to validate registry path. According to Docker Distribution Registry docs it must match regexp [a-z0-9]+(?:[._-][a-z0-9]+)

A repository name is broken up into path components. A component of a repository name must be at least one lowercase, alpha-numeric characters, optionally separated by periods, dashes or underscores. More strictly, it must match the regular expression [a-z0-9]+(?:[._-][a-z0-9]+)*. as per docker/distribution/blob/master/docs/spec/api.md.

This regexp does not contain uppercase characters, so projects that have uppercase letters in path had container registry not working properly.

Does this MR meet the acceptance criteria?

  • Tests added for this bug

What are the relevant issue numbers?

Closes #30880 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Grzegorz Bizon resolved all discussions

    resolved all discussions

  • Kamil Trzcińśki approved this merge request

    approved this merge request

  • Kamil Trzcińśki resolved all discussions

    resolved all discussions

  • mentioned in commit 8568a02e

  • mentioned in commit 78854cd8

  • Picked into 9-1-stable, will go into 9.1.0-RC2

  • Please register or sign in to reply
    Loading