Allow OAuth clients to push code

What does this MR do?

• OAuth clients can currently fetch code using the access token as a password
• This MR expands their ability to allow pushing code using the access token as a password
• OAuth clients can currently get around this limitation by creating a deploy key with push access

What are the relevant issue numbers?

• Closes #30305 (closed)

added 1 commit

• ae2533c5 - Allow OAuth clients to push code

Compare with previous version

mentioned in issue #30305 (closed)

changed milestone to %9.2

marked the checklist item Meta as completed

marked the checklist item Check for clean merge with EE as completed

added 1 commit

• bee780e8 - Allow OAuth clients to push code

Compare with previous version

@adamniedzielski: Could you please take a look at this for the initial review? Please feel free to reassign if you're busy.

assigned to @adamniedzielski

@timothyandrew Thanks! The change is quite straightforward from the code perspective, so no comments from me .

However, I'd like to confirm that we want to raise the access level here at all. I tracked down the commit that prevents pushing code when authenticated with OAuth - https://gitlab.com/gitlab-org/gitlab-ce/commit/79e4bb8d0b3b74ddd185677e4828d737788c3b1a

@ayufan was it an intentional change? please review this merge request.

assigned to @ayufan

@ayufan Ping!

@timothyandrew I don't think so. It seems that I assumed that OAuth should have read-only, which seems to be bug that you did fix.

assigned to @timothyandrew

marked the checklist item Reviewer as completed

@rymai: Could you please take a look at this? Feel free to reassign if busy!

assigned to @rymai

approved this merge request

@timothyandrew Thanks, looks good to me!

marked the checklist item Maintainer as completed

marked the checklist item Review as completed