After Trace#limit, we seek to the next line in case
What does this MR do?
Make the trace read less than LIMIT_SIZE, by seeking to the next newline. This is still possible to cut into something, but much unlikely to happen. For traces having long lines, we could be discarding too much. We could deal with that in the next iteration.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary - Tests
-
Added for this feature/bug
-
What are the relevant issue numbers?
Closes #30796 (closed)
Merge request reports
Activity
mentioned in merge request !10665 (closed)
changed milestone to %9.1
added 1 commit
- b07b8a5f - Don't seek at all if the log is small anyway
@ayufan Should be good now!
assigned to @ayufan
@ayufan Wait :( Tests should be updated accordingly.
assigned to @godfat
added 1 commit
- 0a3c98a7 - Update tests for the fact that we would skip one line
@ayufan Tests are not running, but could you please review?
assigned to @ayufan
enabled an automatic merge when the pipeline for 0a3c98a7 succeeds
mentioned in commit 7761afe0
mentioned in commit c1c0e9e0
Please register or sign in to reply