Skip to content
Snippets Groups Projects

Refactor group search out of global search

Merged Nick Thomas requested to merge (removed):30615-refactor-global-search into master
All threads resolved!

What does this MR do?

Add Search::GroupService and uses it instead of Search::GlobalService for group search

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Not necessarily in CE, but certainly in EE, this logic was getting too complicated. See https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1649

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #30615 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @nick.thomas thanks, couple of questions. Now off to the EE one!

  • Nick Thomas added 155 commits

    added 155 commits

    Compare with previous version

  • Nick Thomas resolved all discussions

    resolved all discussions

  • Nick Thomas added 1 commit

    added 1 commit

    • ab529cdd - Refactor group search out of global search

    Compare with previous version

  • assigned to @smcgivern

  • username-removed-443319 approved this merge request

    approved this merge request

  • changed milestone to %9.2

  • mentioned in commit bdc0fc7f

  • Please register or sign in to reply
    Loading