Resolve "start discussion toggle clicking divider causes UI break"

What does this MR do?

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes #30951 (closed)

So I found a problem with the allowEmpty config and thats that then multiple inputs can incorrectly because out of sync. I think we need a way to see if a clicked item should be clickable from core. Maybe we could just use pointer-events

So I was taking a look at this. I think just applying pointer-events: none; to the .divider class is best. This deals with more than just disabling any clicks and is simple. I will add to droplab docs https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10569 that if you want to make a list item non interactive, you should apply pointer-events: none;.

mentioned in merge request !10569 (merged)

unmarked as a Work In Progress

I realised that pointer-events: none; wont protect against synthetic clicks. Adding some IGNORE_CLASS functionality to kill a click event before its dispatched.

added 3 commits

• c94f0c72 - Added allowEmpty config property
• fc8b317f - Protected against synthetic clicks and added feature scenario
• a9cfaafd - Updated unit specs

Compare with previous version

Want to review @alfredo1?

assigned to @alfredo1

changed milestone to %9.1

mentioned in issue #30864 (closed)

@lbennett is this going to be the definitive fix? I feel like this is going to happen again while we keep filters as plain objects. Just a thought.

approved this merge request

@lbennett Code looks good to me.

merged

mentioned in commit b638e45c

Picked into 9-1-stable, will go into 9.1.0-rc6

mentioned in commit 32f2596e

Thanks @alfredo1

And in response to

is this going to be the definitive fix?

This is a definitive fix as long as we're using the droplab-item-ignore class.

I have added this to the droplab docs https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10808

@lbennett cool. thanks for clarifying