Destroy tooltip in async buttons and dropdowns
What does this MR do?
Destroys the tooltip in async buttons and dropdowns
Screenshots
Does this MR meet the acceptance criteria?
- Tests
-
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #30985 (closed)
Merge request reports
Activity
@iamphill can you please review this? Thanks
Edited by Filipa Lacerdaassigned to @iamphill
-
When I opened https://gitlab.com/gitlab-org/gitlab-ce/issues/30985, I also found that refreshing the page without updating the cancel button state was disorienting. Is there any way to easily fix that, or is the logic too ingrained for a quick fix?
assigned to @filipa
mentioned in issue #30864 (closed)
-
Thank you @brycepj !
When I opened https://gitlab.com/gitlab-org/gitlab-ce/issues/30985, I also found that refreshing the page without updating the cancel button state was disorienting. Is there any way to easily fix that, or is the logic too ingrained for a quick fix?
Do you mean refreshing the page while the button has the loading icon, while the request is being made?
I can't reproduce any problem
Edited by Filipa Lacerda added 27 commits
-
baaaf4e9...bbd83376 - 25 commits from branch
master - 4038d50d - Merge branch 'master' into 30985-cancel-pipelines
- 8752b99f - Only destroy the component's tooltip
-
baaaf4e9...bbd83376 - 25 commits from branch
-
-
@iamphill can you please review this? Thank you! :)
assigned to @iamphill
assigned to @filipa
added 18 commits
-
dbbcb32c...a9da3743 - 17 commits from branch
master - 6c3038e8 - Merge branch 'master' into 30985-cancel-pipelines
-
dbbcb32c...a9da3743 - 17 commits from branch
mentioned in issue #31135 (closed)
mentioned in issue #31151 (closed)
-
Do you mean refreshing the page while the button has the loading icon, while the request is being made?
Notice how after the cancel is complete, we refresh the page/pipeline index, and it's still possible for me to cancel the pipeline.
Edited by username-removed-408230 @brycepj that seems like a different issue to me. Make an issue?
Tested this merge request locally & it works great!
enabled an automatic merge when the pipeline for 2afff609 succeeds
assigned to @iamphill
mentioned in issue #31155 (moved)
mentioned in commit 046c0e1e
mentioned in commit 99d0a615
mentioned in issue gitlab#9362
