Do not append issuable state to links with custom anchor

What does this MR do?

Do not append issuable state to links with custom anchor. Do not append issuable state to links to comments.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• [ ] Changelog entry added, if necessary
• [ ] Documentation created/updated
• [ ] API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/30916

changed milestone to %9.1

assigned to @smcgivern

@adamniedzielski thanks! One question. I take it that using content is no slower than explicitly managing the children, like we were doing before?

assigned to @adamniedzielski

mentioned in issue #31145 (moved)

@smcgivern we were using content in the initial implementation and then I changed it to explicitly managing the children in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10683/diffs. However, this was not due to the performance, just to correctly handle some nested tags.

We no longer have to handle this case, because we append the state only when the anchor is exactly issue reference, without any HTML tags in the anchor. Thanks for asking about this though, it helped me in finding a minor edge case.

I'd expect using content= to be faster than manually appending a child, because the library can modify an existing node without allocating a temporary one.

added 1 commit

• ba67d11f - Do not append issuable state to links with custom anchor

Compare with previous version

added 1 commit

• 06df283e - Do not append issuable state to links with custom anchor

Compare with previous version

resolved all discussions

assigned to @smcgivern

resolved all discussions

@adamniedzielski https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10789 is MWPS, so please assign back to me after that's merged and the conflicts are fixed.

assigned to @adamniedzielski

added 82 commits

• 06df283e...29ddc15f - 81 commits from branch master
• 1269ee4c - Do not append issuable state to links with custom anchor

Compare with previous version

assigned to @smcgivern

approved this merge request

enabled an automatic merge when the pipeline for 1269ee4c succeeds

merged

mentioned in commit b99853f5

Picked into 9-1-stable, will go into 9.1.0-rc6

mentioned in commit 65a136b4