Skip to content

Fix encoding issue exporting a project

James Lopez requested to merge fix/encoding-issue into master

Returns empty string on UTF8 conversion with U_STRING_NOT_TERMINATED_WARNING error

This is a workaround. Proper fix should be to return the converted string and ignore or warn about the error => https://github.com/brianmario/charlock_holmes/pull/114

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/31186

Apart from the Import/Export, we also call this function from Gitlab::Git::Blame - not sure if there're other implications there. But I assume there shouldn't.

Merge request reports