Skip to content
Snippets Groups Projects

Fix encoding issue exporting a project

Merged James Lopez requested to merge fix/encoding-issue into master
All threads resolved!

Returns empty string on UTF8 conversion with U_STRING_NOT_TERMINATED_WARNING error

This is a workaround. Proper fix should be to return the converted string and ignore or warn about the error => https://github.com/brianmario/charlock_holmes/pull/114

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/31186

Apart from the Import/Export, we also call this function from Gitlab::Git::Blame - not sure if there're other implications there. But I assume there shouldn't.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @jameslopez LGTM, one question about the spec.

  • assigned to @smcgivern

  • username-removed-443319 resolved all discussions

    resolved all discussions

  • username-removed-443319 approved this merge request

    approved this merge request

  • mentioned in commit 38e30516

  • James Lopez resolved all discussions

    resolved all discussions

  • Picked into 9-1-stable, will go into 9.1.0-rc6

  • mentioned in commit 843f52ea

  • Please register or sign in to reply
    Loading