Skip to content

Avoid plucking Todo ids in TodoService

Toon Claes requested to merge tc-no-todo-service-select into master

What does this MR do?

TodoService should not call .select(&:id) on todos, because this is bad performance. So instead use sub-queries, which will result in a single SQL query to the database.

https://docs.gitlab.com/ee/development/sql.html#plucking-ids

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes gitlab-org/gitlab-ce#30374

Merge request reports