Use regex to skip unnecessary reference processing in ProcessCommitWorker
What
Adds regex checking for references to Issue
, ExternalIssue
, Commit
, MergeRequest
or any url
. Uses this to avoid scheduling ProcessCommitWorker
jobs as well as to return early from Mentionable#referenced_mentionables
when called from elsewhere.
Why
Raised as a performance issue in #28359 (closed)
Acceptance criteria
-
Changelog entry added, if necessary -
Tests added for this feature/bug
What are the relevant issue numbers?
Closes #28359 (closed)
Merge request reports
Activity
@jameslopez Can you review?
assigned to @jameslopez
- Resolved by James EJ
- Resolved by James Lopez
- Resolved by James EJ
@jamedjo looks good! Only left a couple of comments.
assigned to @jamedjo
added 1 commit
- 6da17a42 - Use regex to skip unnecessary reference processing in ProcessCommitWorker
added 1 commit
- c3313e5e - Use regex to skip unnecessary reference processing in ProcessCommitWorker
assigned to @jameslopez
- Resolved by James Lopez
@jamedjo thanks! LGTM - just a small question.
assigned to @jamedjo
assigned to @jameslopez
@jamedjo feel free to assign it to a maintainer :)
assigned to @jamedjo
@dzaporozhets Could you maintainer-review?