Skip to content
Snippets Groups Projects

Use regex to skip unnecessary reference processing in ProcessCommitWorker

What

Adds regex checking for references to Issue, ExternalIssue, Commit, MergeRequest or any url. Uses this to avoid scheduling ProcessCommitWorker jobs as well as to return early from Mentionable#referenced_mentionables when called from elsewhere.

Why

Raised as a performance issue in #28359 (closed)

Acceptance criteria

What are the relevant issue numbers?

Closes #28359 (closed)

Merge request reports

Pipeline #8051518 passed

Test coverage 69.46% (0.01%) from 2 jobs

Merged by username-removed-444username-removed-444 7 years ago (May 8, 2017 12:54pm UTC)

Loading

Pipeline #8114855 failed

Pipeline failed for 11ff9fc6 on master

Test coverage 48.25% (0.01%) from 2 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • James Lopez
  • James Lopez
  • @jamedjo looks good! Only left a couple of comments.

  • assigned to @jamedjo

  • James EJ added 1 commit

    added 1 commit

    • 6da17a42 - Use regex to skip unnecessary reference processing in ProcessCommitWorker

    Compare with previous version

  • James EJ added 1 commit

    added 1 commit

    • c3313e5e - Use regex to skip unnecessary reference processing in ProcessCommitWorker

    Compare with previous version

  • James EJ added 2 commits

    added 2 commits

    • a2699288 - Use regex to skip unnecessary reference processing in ProcessCommitWorker
    • 8ac5653e - Cycle analytics specs needed Commit to reference issue

    Compare with previous version

  • assigned to @jameslopez

  • James EJ added 2 commits

    added 2 commits

    • 020295ff - Use regex to skip unnecessary reference processing in ProcessCommitWorker
    • 29519edb - Cycle analytics specs needed Commit to reference issue

    Compare with previous version

  • James Lopez resolved all discussions

    resolved all discussions

  • James Lopez
  • @jamedjo thanks! LGTM - just a small question.

  • assigned to @jamedjo

  • assigned to @jameslopez

  • @jamedjo feel free to assign it to a maintainer :)

  • assigned to @jamedjo

  • Author Maintainer

    @dzaporozhets Could you maintainer-review?

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading