Make namespace owner master of project upon creation
What does this MR do?
When an admin creates a project in the namespace of a user, that user automatically gains master access to that project.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes gitlab-org/gitlab-ce#29446
Merge request reports
Activity
added 129 commits
-
657a1edc...cc52dfab - 128 commits from branch
master
- 13dfbf10 - Make namespace owner master of project upon creation
-
657a1edc...cc52dfab - 128 commits from branch
@dbalexandre Would you mind having a look?
assigned to @dbalexandre
- Resolved by Toon Claes
- Resolved by Toon Claes
- Resolved by Toon Claes
@to1ne Thanks! I left some notes :)
assigned to @to1ne
added 7 commits
-
13dfbf10...3c6fad64 - 6 commits from branch
master
- 93f2c352 - Make namespace owner master of project upon creation
-
13dfbf10...3c6fad64 - 6 commits from branch
added 1 commit
- 9f735ecd - Make namespace owner master of project upon creation
@rymai Can you take care of the second round review please?
assigned to @rymai
- Resolved by Toon Claes
- Resolved by Toon Claes
- Resolved by Toon Claes
@to1ne I had a few remarks, thanks!
assigned to @to1ne
marked the checklist item Changelog entry added, if necessary as completed
marked the checklist item Documentation created/updated as completed
added 111 commits
-
9f735ecd...b5526a2d - 110 commits from branch
master
- 983c71a9 - Make namespace owner master of project upon creation
-
9f735ecd...b5526a2d - 110 commits from branch
marked the checklist item Conform by the merge request performance guides as completed
marked the checklist item Conform by the style guides as completed
marked the checklist item Squashed related commits together as completed
@rymai Thx! Should be good now!
assigned to @rymai
added 23 commits
-
983c71a9...025b04f3 - 22 commits from branch
master
- 69f584ed - Make namespace owner master of project upon creation
-
983c71a9...025b04f3 - 22 commits from branch
enabled an automatic merge when the pipeline for 69f584ed succeeds
mentioned in commit 39ff8099