Skip to content
Snippets Groups Projects

Make namespace owner master of project upon creation

Merged Toon Claes requested to merge tc-make-user-master-project-by-admin into master
All threads resolved!

What does this MR do?

When an admin creates a project in the namespace of a user, that user automatically gains master access to that project.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes gitlab-org/gitlab-ce#29446

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @to1ne Thanks! I left some notes :)

  • Toon Claes resolved all discussions

    resolved all discussions

  • Toon Claes added 7 commits

    added 7 commits

    Compare with previous version

  • Toon Claes added 1 commit

    added 1 commit

    • 9f735ecd - Make namespace owner master of project upon creation

    Compare with previous version

  • Author Developer

    @rymai Can you take care of the second round review please?

  • assigned to @rymai

  • @to1ne I had a few remarks, thanks!

  • Toon Claes resolved all discussions

    resolved all discussions

  • Toon Claes marked the checklist item Changelog entry added, if necessary as completed

    marked the checklist item Changelog entry added, if necessary as completed

  • Toon Claes marked the checklist item Documentation created/updated as completed

    marked the checklist item Documentation created/updated as completed

  • Toon Claes added 111 commits

    added 111 commits

    Compare with previous version

  • Toon Claes marked the checklist item Conform by the merge request performance guides as completed

    marked the checklist item Conform by the merge request performance guides as completed

  • Toon Claes marked the checklist item API support added as completed

    marked the checklist item API support added as completed

  • Toon Claes marked the checklist item Conform by the style guides as completed

    marked the checklist item Conform by the style guides as completed

  • Toon Claes marked the checklist item Branch has no merge conflicts with master (if it does - rebase it please) as completed

    marked the checklist item Branch has no merge conflicts with master (if it does - rebase it please) as completed

  • Toon Claes marked the checklist item Squashed related commits together as completed

    marked the checklist item Squashed related commits together as completed

  • Author Developer

    @rymai Thx! Should be good now!

  • assigned to @rymai

  • Thanks, looks good to me! :heart:

  • username-removed-128633 approved this merge request

    approved this merge request

  • Toon Claes added 23 commits

    added 23 commits

    Compare with previous version

  • username-removed-128633 approved this merge request

    approved this merge request

  • username-removed-128633 enabled an automatic merge when the pipeline for 69f584ed succeeds

    enabled an automatic merge when the pipeline for 69f584ed succeeds

  • mentioned in commit 39ff8099

  • Please register or sign in to reply
    Loading