Skip to content

WIP: Duplicate "View it on GitLab" link - Email on push

username-removed-977107 requested to merge mmaya/gitlab-ce:22297-email-on-push-layout into master

Duplicate "View it on GitLab" link - Email on push - Resolves: #22297 (moved)

Duplicate the "View it on GitLab" link at the top of the message of the push on emails and keep it at the bottom too in order to improve usability for Gmail and Google Apps users.

When using Google Apps or Gmail, the email content is truncated if the list of changes is too big, so the link in the footer is not displayed. To get it, the user has to click on "View entire message", then scroll to the end of the message opened in the new window to finally click on it.

This commit implements the necessary changes and the Rspec tests.

  • Before screenshots

IMG_7306 IMG_7307

  • After screenshots

IMG_7304 IMG_7305

Screenshots from letter opener.

  • Changelog entry [22297-Email-on-Push-Consider-to move-the-"View it on GitLab"-link]added
  • The original documentation of the emails on push doesn't mention the "View it on Gitlab" link, so I thought it wasn't worth to update the text (/doc/user/project/integrations/emails_on_push.md). Please, let me know if it's necessary.

Closes #22297 (moved)

Merge request reports