Skip to content
Snippets Groups Projects

Increase code coverage for admin/cohorts page

Merged Increase code coverage for admin/cohorts page
dz-add-cohort-spec into master
All threads resolved!
Merged username-removed-444 requested to merge dz-add-cohort-spec into master
All threads resolved!

I noticed that app/controllers/admin/cohorts_controller.rb has no test coverage so decided to add some tests to it.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-443319
    username-removed-443319 @smcgivern ·
    Contributor

    @dzaporozhets thanks for adding this! I agree that the feature spec makes sense, but I'm not really sure what value the controller spec is adding 🤔

  • username-removed-443319 assigned to @dzaporozhets

    assigned to @dzaporozhets

  • username-removed-444 added 1 commit

    added 1 commit

    • 1c408df2 - Increase code coverage for admin/cohorts page

    Compare with previous version

  • username-removed-444 resolved all discussions

    resolved all discussions

  • username-removed-444 assigned to @smcgivern

    assigned to @smcgivern

  • username-removed-443319 approved this merge request

    approved this merge request

  • username-removed-443319 enabled an automatic merge when the pipeline for 1c408df2 succeeds

    enabled an automatic merge when the pipeline for 1c408df2 succeeds

  • username-removed-443319
    username-removed-443319 @smcgivern ·
    Contributor

    Thanks @dzaporozhets! ❤️

  • username-removed-444 added test label

    added test label

  • username-removed-443319 merged

    merged

  • username-removed-443319 mentioned in commit c20acd13

    mentioned in commit c20acd13

    • Please register or sign in to reply