Skip to content

Use grpc 1.2.5

What does this MR do?

Update the 'grpc' gem from 1.1.2 to 1.2.5.

Are there points in the code the reviewer needs to double check?

There is some risk in this change. We upgraded to grpc 1.2.2 not long ago but we had to revert that change because it affected the stability of Unicorn.

As far as we understand the issues in grpc 1.2.2 were caused by a new background thread. This grpc change was reverted in grpc 1.2.5, see https://github.com/grpc/grpc/releases/tag/v1.2.5 .

We now have a regression test for the Unicorn stability issue that grpc 1.2.2 caused. https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10818

Why was this MR needed?

Grpc 1.1.x and older have a bug that prevents them from loading when compiled from source.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/31143

Closes https://gitlab.com/gitlab-org/gitaly/issues/197

Merge request reports