Skip to content
Snippets Groups Projects

Resolve "Combine all GitLab workflow documentation to CONTRIBUTING.md"

Merged username-removed-128633 requested to merge docs/30141-improve-contributing-guide into master
All threads resolved!

What does this MR do?

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #30141 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-128633
  • username-removed-128633
  • username-removed-128633
  • username-removed-128633
  • username-removed-128633
  • username-removed-128633
  • username-removed-128633
  • username-removed-128633
  • username-removed-128633
  • username-removed-128633
  • added 4 commits

    • 11661d1d - Move retro/kickoff doc to PROCESS.md
    • 0374e22a - Improve the merge request guidelines and DoD in CONTRIBUTING.md
    • f644b8c8 - Improve the Code review guidelines documentation
    • cb87903c - Update ToC of CONTRIBUTING.md and PROCESS.md

    Compare with previous version

  • @rspeicher Could you please review this one and https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/5815 (they're should go in together)? Thanks!

  • username-removed-128633 unmarked as a Work In Progress

    unmarked as a Work In Progress

  • @rymai LGTM, just a few suggestions. 👍

  • assigned to @rymai

  • @rspeicher Thanks, feedback addressed! :)

  • added 1 commit

    • 38c29f87 - Improving copy of CONTRIBUTING.md, PROCESS.md, and code_review.md

    Compare with previous version

  • I believe the conflict in CONTRIBUTING.md from ee_compat_check can be ignored since the file should be the same in EE anyway.

  • Robert Speicher resolved all discussions

    resolved all discussions

  • Robert Speicher approved this merge request

    approved this merge request

  • Robert Speicher mentioned in commit 985737fd

    mentioned in commit 985737fd

  • Please register or sign in to reply
    Loading