Add support for commit diff ignore_whitespace_change and paths flags

What does this MR do?

It re-enables CommitController#show Gitaly migration, now that we support ignore_whitespace_change and paths flags in Gitaly server.

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

gitaly#198 (closed)

added 2 commits

• 36f93f5e - Re-enable Gitaly commit_raw_diff feature
• dbb47a02 - Remove stubbing from Gitlab::GitalyClient::Commit specs

Compare with previous version

added 30 commits

• dbb47a02...9fce7c8e - 28 commits from branch master
• ee64a1ba - Re-enable Gitaly commit_raw_diff feature
• 26bf3cca - Remove stubbing from Gitlab::GitalyClient::Commit specs

Compare with previous version

assigned to @jacobvosmaer-gitlab

@ahmadsherif do we now have tests that actually send look at the CommitDiff diffs return by Gitaly? I can't tell by looking at this MR's changes.

assigned to @ahmadsherif

@jacobvosmaer-gitlab Yes, the ones I'm aware of are in spec/features/expand_collapse_diffs_spec.rb and spec/models/commit_spec.rb.

OK. No further questions from me. :)

added Gitaly label

added 393 commits

• 26bf3cca...8a5c95d2 - 391 commits from branch master
• 5ac1580c - Re-enable Gitaly commit_raw_diff feature
• 4766bcb1 - Remove stubbing from Gitlab::GitalyClient::Commit specs

Compare with previous version

added 393 commits

• 26bf3cca...8a5c95d2 - 391 commits from branch master
• 5ac1580c - Re-enable Gitaly commit_raw_diff feature
• 4766bcb1 - Remove stubbing from Gitlab::GitalyClient::Commit specs

Compare with previous version

mentioned in merge request !11122 (merged)

added 321 commits

• 4766bcb1...6ad3814e - 319 commits from branch master
• da15d309 - Re-enable Gitaly commit_raw_diff feature
• efb7917a - Remove stubbing from Gitlab::GitalyClient::Commit specs

Compare with previous version

unmarked as a Work In Progress

marked the checklist item Added for this feature/bug as completed

marked the checklist item All builds are passing as completed

marked the checklist item Conform by the merge request performance guides as completed

marked the checklist item Conform by the style guides as completed

marked the checklist item Branch has no merge conflicts with master (if it does - rebase it please) as completed

marked the checklist item Squashed related commits together as completed

assigned to @rspeicher

@ahmadsherif One minor question. I don't feel strongly about it so feel free to resolve and assign back.

assigned to @ahmadsherif

added 2 commits

• 34cd1097 - Re-enable Gitaly commit_raw_diff feature
• 2f60a402 - Remove stubbing from Gitlab::GitalyClient::Commit specs

Compare with previous version

assigned to @rspeicher

resolved all discussions

approved this merge request

enabled an automatic merge when the pipeline for 2f60a402 succeeds

merged

mentioned in commit 8b9cd3c0