Resolve "Make the DB name a suffix of the first part of jobs' name"

EE MR: gitlab-ee!1820

What does this MR do?

This makes the DB name a suffix of the first part of jobs' name.

It also:

• makes the jobs' names more consistent & concise
• groups related jobs together
• DRY up a common :only array
• improves the organization of scripts/prepare_build.sh

Why was this MR needed?

To avoid breaking master as done in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10946.

Closes #31693 (closed)

Will jobs grouping work as expected? We'll see.

Hmm, seems like the grouping works only for jobs ending with x y. I guess we'll have to put the DB name first then... :(

added 1 commit

• 61686372 - Move the DB name at the end of the first jobs' name word and prepend it with a dash

Compare with previous version

added 79 commits

• 61686372...185fd98f - 74 commits from branch master
• d5937ee2 - Revert "Merge branch 'revert-f2fc716c' into 'master'"
• 59f3e758 - Move DB name to the last part of jobs' name
• 9fbf6961 - Move the DB name at the end of the first jobs' name word and prepend it with a dash
• 18544985 - Factorize common :only definition in .gitlab-ci.yml
• 1f834719 - Reorganize static analysis and DB-related jobs

Compare with previous version

added 1 commit

• fbab677a - Fix a transient failure

Compare with previous version

added 146 commits

• fbab677a...593b6469 - 141 commits from branch master
• db64ca79 - Revert "Merge branch 'revert-f2fc716c' into 'master'"
• 598a7d42 - Move DB name to the last part of jobs' name
• 02598908 - Move the DB name at the end of the first jobs' name word and prepend it with a dash
• d17f56c6 - Factorize common :only definition in .gitlab-ci.yml
• 72e52584 - Reorganize static analysis and DB-related jobs

Compare with previous version

added 36 commits

• 72e52584...68c12e15 - 31 commits from branch master
• 1ccb18d0 - Revert "Merge branch 'revert-f2fc716c' into 'master'"
• 829193b9 - Move DB name to the last part of jobs' name
• 0461e925 - Move the DB name at the end of the first jobs' name word and prepend it with a dash
• 86ac57e6 - Factorize common :only definition in .gitlab-ci.yml
• 9ab9152f - Reorganize static analysis and DB-related jobs

Compare with previous version

added 1003 commits

• 9ab9152f...051aaf8e - 999 commits from branch master
• 1832b054 - Revert "Merge branch 'revert-f2fc716c' into 'master'"
• 0c19f7cb - Move the DB name at the end of the first jobs' name word and prepend it with a dash
• 05bf8266 - Factorize common :only definition in .gitlab-ci.yml
• 06399b1a - Reorganize static analysis and DB-related jobs

Compare with previous version

added 69 commits

• 06399b1a...a5f06563 - 65 commits from branch master
• 78d8f4af - Revert "Merge branch 'revert-f2fc716c' into 'master'"
• 6813c9ef - Move the DB name at the end of the first jobs' name word and prepend it with a dash
• 33de07ba - Factorize common :only definition in .gitlab-ci.yml
• 23af4d6e - Reorganize static analysis and DB-related jobs

Compare with previous version

added ci-build label

@rspeicher What do you think?

assigned to @rspeicher

changed milestone to %9.3

@rymai It looks fine, but the MR title is no longer accurate, right? Also what's the benefit here?

added 1 commit

• 902bd84b - Reorganize static analysis and DB-related jobs

Compare with previous version

Also what's the benefit here?

@rspeicher Per the issue:

!10946 (merged) broke the migration path mysql jobs because scripts/prepare_build.sh expect the DB name to be the second part of the job's name.

Basically this:

• makes the jobs' names more consistent & concise
• groups related jobs together
• DRY up a common :only array
• improves the organization of scripts/prepare_build.sh

Note: I've removed the bundler:audit job since it's now part of static-analysis.

changed title from Resolve "Make the DB name the last part of jobs' name" to Resolve "Make the DB name a suffix of the first part of jobs' name"

approved this merge request

@rymai https://gitlab.com/gitlab-org/gitlab-ce/builds/16515231 looks legit, but I'm confused why the EE version didn't have the same failures.

assigned to @rymai

@rspeicher This was a transient failure after all (but I restarted the failed job before seeing that it already passed after a retry..)! :P

merged