Skip to content
Snippets Groups Projects

WIP: Resolve "Display performance deltas between app deployments on Merge Request workflow"

This MR is a copy of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10981 to facilitate initial review.

Do not merge.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @pchojnacki I marked this MR as WIP so that we would never merge this accidentally. I didn't check the tests very carefully as it seems still in progress? Others were all minor comments. Looks much better than before, thanks!

  • added 1 commit

    • 4ba54c71 - remove unused metho, and cleanup some code. Add more queries to deployment queries.

    Compare with previous version

  • added 1 commit

    • b5f43cf7 - Remove unused method. Add more queries to deployment queries.

    Compare with previous version

  • Thanks for looking into it. I'm happy you liked it, I did write a few iterations before to hash out what works best because on top of this change new EE only features will also be implemented.

  • added 1 commit

    • 3cff9460 - Remove unused method. Add more queries to deployment queries.

    Compare with previous version

  • @pchojnacki No problems. Thank you for making it easier to maintain. Let me know if you need more feedback.

  • username-removed-676946 resolved all discussions

    resolved all discussions

  • added 1 commit

    • a50804f4 - Wrap BaseQuery in module hierarchy

    Compare with previous version

  • added 1 commit

    • bc3b619e - Custom queries for prometheus

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading