Use AjaxCache in Droplab Ajax plugin
What does this MR do?
Use AjaxCache
instead of Droplabs internal cache for dropdown data.
Why was this MR needed?
Previously, duplicate requests were made to the same URL from dropdown and non-dropdown code.
What are the relevant issue numbers?
fixes #31897 (closed)
Merge request reports
Activity
changed milestone to %9.2
mentioned in merge request !11170 (merged)
@jschatz1 Can you please review? This solves the duplicate request you were experiencing.
assigned to @jschatz1
mentioned in commit b8f27513
added 23 commits
-
bd8db1f8...387b4410 - 22 commits from branch
master
- b8f27513 - Use AjaxCache in Droplab Ajax plugin (!11171 (merged))
-
bd8db1f8...387b4410 - 22 commits from branch
I think https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11222 attempts to solve the failing test.
assigned to @winh
mentioned in commit 1111bec6
added 116 commits
-
b8f27513...1daa133c - 115 commits from branch
master
- 1111bec6 - Use AjaxCache in Droplab Ajax plugin (!11171 (merged))
-
b8f27513...1daa133c - 115 commits from branch
@jschatz1 Rebased on master and tests are passing now.
ee_compat_check
failed, so I'll create an EE merge request as soon as this is reviewed.assigned to @jschatz1
@ClemMakesApps you wanna look at this?
assigned to @ClemMakesApps
- Resolved by Winnie Hellmann
Just one comment and everything else LGTM. Thanks for this @winh
assigned to @winh
mentioned in commit 382995c2
added 1 commit
- 382995c2 - Use AjaxCache in Droplab Ajax plugin (!11171 (merged))
assigned to @ClemMakesApps
assigned to @lbennett
Did we decide to make this %9.3 ?
Thanks @winh and @ClemMakesApps.
@ClemMakesApps IIRC this was an ideal piece missing from a deliverable so should be picked. Sorry RMs! :(
mentioned in commit db4bbbab
We decided to move !11170 (merged) to %9.3, so I guess this should be, too.
Edited by Winnie Hellmannchanged milestone to %9.3