Prevent vue.esm.js from being bundled into the primary JS bundle
What does this MR do?
exports sidebar/event_hub functions onto window.emitSidebarEvent
to bypass including the entire Vue library in places where it shouldn't be included.
Are there points in the code the reviewer needs to double check?
the users_select.js dropdown should continue to work as it did before (test coverage should validate this)
Why was this MR needed?
when vue.esm.js gets included in unexpected places it ends up needlessly inflating our bundle sizes and adding "Vue is running in development mode" garbage to our rspec logs.
Screenshots (if relevant)
n/a
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
closes #31966 (closed)
Merge request reports
Activity
Filter activity
Please register or sign in to reply