Automatically close user dropdown for CE

What does this MR do?

Makes it so that selecting an assignee in the user dropdown automatically closes the dropdown.

Are there points in the code the reviewer needs to double check?

Shouldn't be

Why was this MR needed?

Improve usability

Screenshots (if relevant)

None

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes #31987 (closed)

added 1 commit

• c20d6a89 - Add spec

Compare with previous version

added 1 commit

• 03768045 - Add spec

Compare with previous version

added 1 commit

• 5702a5bb - Add spec

Compare with previous version

added 53 commits

• 5702a5bb...f2b72d79 - 50 commits from branch master
• dbbe15e6 - Automatically close user dropdown for CE
• a72bc103 - Add spec
• 0b06ba0b - Fix issue spec

Compare with previous version

added 1 commit

• f154a9ec - Fix sidebar spec

Compare with previous version

added 1 commit

• be646ba0 - Add helper to disable css animation in rspec

Compare with previous version

@smcgivern @jschatz1 can you review?

assigned to @smcgivern

Actually @mikegreiling, can you review first?

assigned to @mikegreiling

added frontend label

changed milestone to %9.2

resolved all discussions

just a few comments/questions, otherwise LGTM

assigned to @ClemMakesApps

added 1 commit

• 9740f6a7 - Add additional EE check

Compare with previous version

assigned to @mikegreiling

resolved all discussions

added 1 commit

• 28ebd706 - Remove unnecessary comment

Compare with previous version

added 1 commit

• 2c5e70be - Fix conflict on users_select

Compare with previous version

added 285 commits

• 2c5e70be...ec1a3c09 - 284 commits from branch master
• c1e324ee - Merge branch 'master' into '31987-automatically-close-assignee-select-dropdown-a…

Compare with previous version

added 1 commit

• f5d2cf80 - Merge branch 'master' into '31987-automatically-close-assignee-select-dropdown-a…

Compare with previous version

@smcgivern can you review?

assigned to @smcgivern

assigned to @rspeicher

@ClemMakesApps Two notes, thanks.

assigned to @ClemMakesApps

mentioned in merge request !11324 (merged)

added 1 commit

• c316ce25 - Merge branch 'master' into '31987-automatically-close-assignee-select-dropdown-a…

Compare with previous version

added 3 commits

• a1d44a9e - Fix rubocop
• 87277793 - Add test.js and test.css to disable animations during testing and include these …
• 7d070129 - Fix form spec

Compare with previous version

resolved all discussions

I cherry picked @lbennett's fix for disabling css animation (It is already in master)

I realized that some of our existing tests can already be modified to check that the dropdown automatically closes so we don't need to add any new specs.

@iamphill can you review?

assigned to @iamphill

Once it looks good to you, I'll create the EE MR

assigned to @ClemMakesApps

resolved all discussions

added 1 commit

• 5caa9898 - Use to toggle the dropdown

Compare with previous version

assigned to @iamphill

assigned to @ClemMakesApps

resolved all discussions

added 1 commit

• fbe1e00e - Remove unnecessary hidden()

Compare with previous version

assigned to @iamphill

approved this merge request

merged

mentioned in commit a4933772

added regression label

mentioned in commit 69019797

mentioned in merge request !11530 (merged)

@ClemMakesApps: This MR doesn't apply cleanly onto 9-2-stable. Could you please fix the conflicts in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11530?