Make all Serializers receive `current_user` instead `user` [CE]

https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1711 passes current_user to the MergeRequestSerializer, which passes current_user the it's Entity leafs (e.g. PipelineSerializer). The problem is that new leafs were added while https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1711 wasn't merged, causing conflicts and more overhead about current_user or user usage.

This MR makes ensures all entities receive current_user, avoiding errors and overhead.

EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1869

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

@grzesiek We think got bad spec situation for the DeploymentsController. Inner leafs of DeploymentsEntity are expecting current_user, but since we don't reach them on the specs, it seems to have passed on master.

Edit: DeploymentSerializer doesn't need to receive user or current_user for that particular usage, so I'm removing it for now.

mentioned in issue #32099 (moved)

added 1 commit

• 368bf99e - Remove unnecessary user hash being passed to DeploymentSerializer

Compare with previous version

@oswaldo I left just a single question! Thanks for resolving this user/current_user chaos 😸

changed title from Ensure all Serializers receive current_user instead user [CE] to Make all Serializers receive current_user instead user [CE]

Thanks @grzesiek, answered the question 😃

mentioned in issue #32112 (moved)

approved this merge request

resolved all discussions

merged

mentioned in commit bae0a060

Picked into 9-2-stable, will go into 9.2.0-rc1

mentioned in commit 6d81a382

mentioned in issue #31934 (closed)