Skip to content
Snippets Groups Projects

MRWidget: Implement new design for nothing to commit state.

Merged username-removed-502136 requested to merge acet-mr-widget-nothing-to-commit-state into master
All threads resolved!

Things to do

  • Fix mock canCreateFile
  • Add tests

Screenshots

Screen_Shot_2017-05-10_at_23.10.15

Screen_Shot_2017-05-10_at_23.10.30

Screen_Shot_2017-05-10_at_23.10.53

Fixes #29320 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Filipa Lacerda
  • Filipa Lacerda
  • @fatihacet looking good! Left some suggestions :blush:

  • username-removed-502136 resolved all discussions

    resolved all discussions

  • added 184 commits

    • 8d6c73cd...9bef3f6d - 180 commits from branch master
    • 583f4e04 - MRWidget: Implement new design for nothing to commit state.
    • 3c033138 - Returns new_blob_path only when user can push_code to project
    • 56eaa1fa - Add new_blob_path to MR json schema
    • 1dc10e90 - MRWidget: Fix specs and remove duplicate key in store.

    Compare with previous version

  • username-removed-502136 marked the checklist item Add tests as completed

    marked the checklist item Add tests as completed

  • username-removed-502136 marked the checklist item Fix mock canCreateFile as completed

    marked the checklist item Fix mock canCreateFile as completed

  • added 1 commit

    • 142ca9e7 - MRWidget: Fix specs and remove duplicate key in store.

    Compare with previous version

  • added 1 commit

    • a16be025 - MRWidget: Fix specs and address WIP comments.

    Compare with previous version

  • username-removed-502136 unmarked as a Work In Progress

    unmarked as a Work In Progress

  • @filipa this is good to go. Passing to you.

  • Filipa Lacerda
  • Filipa Lacerda
  • @fatihacet left some comments :grin: looking good :thumbsup:

  • username-removed-502136 resolved all discussions

    resolved all discussions

  • added 211 commits

    • a16be025...bcc5135b - 206 commits from branch master
    • ca3d868c - MRWidget: Implement new design for nothing to commit state.
    • 3f6121f2 - Returns new_blob_path only when user can push_code to project
    • a2dbb693 - Add new_blob_path to MR json schema
    • 9f800079 - MRWidget: Fix specs and address WIP comments.
    • 48a4a934 - Address MR comments.

    Compare with previous version

  • @filipa pushed the fixes, they are just very minor string changes. Assigning you to enable auto merge. I will keep an eye on the pipeline in case it fails.

  • username-removed-502136 resolved all discussions

    resolved all discussions

  • Thank you @fatihacet :tada:

  • Can you please create an ee branch?

  • Filipa Lacerda approved this merge request

    approved this merge request

  • Filipa Lacerda mentioned in commit 433070dc

    mentioned in commit 433070dc

  • mentioned in issue #32809 (closed)

  • Please register or sign in to reply
    Loading