Skip to content
Snippets Groups Projects

Only rename namespaces and projects with an invalid path

Merged Bob Van Landuyt :neckbeard: requested to merge bvl-fix-dynamic-path-query into master
All threads resolved!

In staging we were renaming a namespace that shouldn't be renamed because its path ended in a -, which is an illegal path.

We were querying for routes like this: %#{path}, but we should try to match the entire path of a name, so the route would be like %/#{path} or #{path}.

This is needed to fix this migration error in RC1: https://gitlab.com/gitlab-org/gitlab-ce/issues/31934#note_29424556

@selfup

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • James Lopez
  • @reprazent thanks! That was super fast 🚀

    Had some minor comments/questions. Feel free to pass it to a maintainer for a final review (in the Americas). Thanks!

  • assigned to @reprazent

  • added 1 commit

    • 3760a7c2 - Only rename namespaces and projects with an invalid path

    Compare with previous version

  • Bob Van Landuyt :neckbeard: resolved all discussions

    resolved all discussions

  • @DouweM Could you take a look as well, we would like to pick this into RC2 😄

    Edited by Bob Van Landuyt :neckbeard:
  • assigned to @reprazent

  • Douwe Maan changed milestone to %9.2

    changed milestone to %9.2

  • James Lopez resolved all discussions

    resolved all discussions

  • James Lopez added 1 commit

    added 1 commit

    Compare with previous version

  • assigned to @DouweM

  • Douwe Maan approved this merge request

    approved this merge request

  • Douwe Maan enabled an automatic merge when the pipeline for 48ffec9e succeeds

    enabled an automatic merge when the pipeline for 48ffec9e succeeds

  • merged

  • Douwe Maan mentioned in commit 40242003

    mentioned in commit 40242003

  • Picked into 9-2-stable, will go into 9.2.0-rc2.

  • Douwe Maan mentioned in commit c3160175

    mentioned in commit c3160175

  • Please register or sign in to reply
    Loading