Only rename namespaces and projects with an invalid path
In staging we were renaming a namespace that shouldn't be renamed because its path ended in a -
, which is an illegal path.
We were querying for routes like this: %#{path}
, but we should try to match the entire path of a name, so the route would be like %/#{path}
or #{path}
.
This is needed to fix this migration error in RC1: https://gitlab.com/gitlab-org/gitlab-ce/issues/31934#note_29424556
Merge request reports
Activity
- Resolved by James Lopez
- Resolved by James Lopez
- Resolved by Bob Van Landuyt :neckbeard:
- Resolved by Bob Van Landuyt :neckbeard:
@reprazent thanks! That was super fast
🚀 Had some minor comments/questions. Feel free to pass it to a maintainer for a final review (in the Americas). Thanks!
assigned to @reprazent
mentioned in issue #31934 (closed)
added 1 commit
- 3760a7c2 - Only rename namespaces and projects with an invalid path
@DouweM Could you take a look as well, we would like to pick this into RC2
😄 Edited by Bob Van Landuyt :neckbeard:assigned to @DouweM
assigned to @reprazent
changed milestone to %9.2
assigned to @DouweM
enabled an automatic merge when the pipeline for 48ffec9e succeeds
mentioned in commit 40242003
mentioned in commit c3160175