Step 2: Job page header component
What does this MR do?
Step 2 of rewriting job show page in vue.js: - Main MR is https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10987
- Adds fake data - to be deleted when we have backend
- Adds ci header reusable component based on UX mockups: https://gitlab-org.gitlab.io/gitlab-design/hosted/27724-large-build-logs-spec-previews/#artboard0 and pipeline header - to be used in both job and pipeline show pages
- Adds timeago tooltip shared component port of ruby helper
- Adds a layer for data validation between render function and API response
Screenshots (if relevant)
Currently renders:
User image to be added when https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10718 is merged
Does this MR meet the acceptance criteria?
- Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together
Merge request reports
Activity
added 1 commit
- 418f5d3f - Adds reusable header component for job and pipeline
@iamphill pipeline will always fail in this MR. This is step 2 of making job page realtime :)
Can you please review it? Thank you!
assigned to @iamphill
assigned to @filipa
-
Thank you @iamphill! Nice catches!
I think I covered them all
assigned to @iamphill
mentioned in commit 7b0eee71
34 35 mixins: [tooltipMixin], 36 37 computed: { 38 cssClass() { 39 return this.shortFormat ? 'js-short-timeago' : 'js-timeago'; 40 }, 41 42 tooltipTitle() { 43 return gl.utils.formatDate(this.time); 44 }, 45 46 timeFormated() { 47 const timeago = gl.utils.getTimeago(); 48 49 return timeago.format(this.finishedTime); -
@filipa where is
finishedTime? I think you meantthis.time?Edited by Luke "Jared" Bennett -
I'm using this over in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11375/diffs#7fccca5ef73750b7ece13054438534d0d0e39c36_0_2. I've made this change on that side, let me know if you make any other changes beyond that so I can keep them in sync. Thanks for the component!
Edited by Luke "Jared" Bennett -
where is
finishedTime? I think you meantthis.time?
I will make this change in a new MR and I will ping you there!
-
@lbennett your MR is for 9.2, this one is part of a deliverable for 9.3
I don't think we should introduce a component in 9.2. I thin it's better to fix the problem in 9.2 without adding components and then we'll refactor it, what do you think?
@iamphill you are working on realtime issues, maybe you can help @lbennett
Edited by Filipa Lacerda
mentioned in merge request !11726 (merged)
