Skip to content
Snippets Groups Projects

Move issuable bulk edit form into a sidebar

This MR moves Issue and MR bulk editing into a sidebar.

Some additional changes were made to improve maintainability of the code:

  • Standardized naming across filenames, selectors, JS variables etc. to use appropriate variations of 'Issuable bulk update'. There were several different naming conventions describing the same feature including 'bulk edit', 'issues bulk assignment' & 'bulk update'.
  • Changed the name of Issuable to IssuableIndex and updated references to it, as it is more accurate and less confusing.
  • Removed some orphaned bulk update code which had fallen out of use (app/views/shared/issuable/_filter.html.haml)

Closes #28340 (closed)

Edited by username-removed-408230

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 2abf823e - Standardize naming on 'bulk-update' and variants'.

    Compare with previous version

  • added 1 commit

    • b66b79c4 - Standardize naming on 'bulk-update' and variants'.

    Compare with previous version

  • added 1 commit

    • 94a8580f - Abstract out bulk edit state change logic into toggle methods.

    Compare with previous version

  • added 1 commit

    • 1e184757 - Improve dependency chain and fix issuable_ids hidden field missing.

    Compare with previous version

  • added 3 commits

    • 2e3f4cb2 - Remove unused enabled-content class.
    • f0ecdc0c - Use button tags instead of plain button element.
    • cd2360ac - Remove unneeded comments.

    Compare with previous version

  • added 2 commits

    • 20fdf322 - Move bulk_update_sidebar into its own view.
    • 0d5eb330 - Move bulk_update_sidebar into its own view.

    Compare with previous version

  • added 1 commit

    • e4b71824 - Move bulk update sidebar out of search bar and up a level.

    Compare with previous version

  • added 1 commit

    • 60e0f4a6 - Used cached ref for update_issuable_ids.

    Compare with previous version

  • username-removed-408230 resolved all discussions

    resolved all discussions

  • added 2 commits

    • 5002c856 - Use consistent spacing in JS.
    • 9fb98098 - Initialize dropdowns only when bulk_update view is loaded.

    Compare with previous version

  • added 1 commit

    • 6dd85594 - Fix dropdown is-default styles and fix dropdown toggles.

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • username-removed-408230 resolved all discussions

    resolved all discussions

  • changed milestone to %9.3

  • added 1 commit

    Compare with previous version

  • username-removed-408230 changed the description

    changed the description

  • added 1 commit

    • 259b7556 - Fixup specs and code to eliminate noisy failures.

    Compare with previous version

  • added 1 commit

    • 5fc76425 - Fix willUpdateLabels and dropdownData.

    Compare with previous version

  • added 2 commits

    • 3a6d1d5d - Ensure dropdown state is update on checkbox state change.
    • 07933d3c - Get tests passing.

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • d8b2cdd6 - Fix ref to static method, and shush eslint some more.

    Compare with previous version

  • username-removed-408230 changed the description

    changed the description

  • @iamphill I thought you'd be the right person to have review this -- do you mind? Btw, I made some notes in the MR description that might help orient you :stuck_out_tongue_winking_eye:

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 9537e224 - Fix up update issues and merge requests specs.

    Compare with previous version

  • Phil Hughes
  • Phil Hughes
  • Phil Hughes
  • Phil Hughes
  • Haven't checked it out yet to test yet.

  • assigned to @brycepj

  • Haven't checked it out yet to test yet.

    That's fine, might as well wait on it til I've addressed your feedback.

  • Based on your gif, it also doesn't match the designs https://gitlab.com/gitlab-org/gitlab-ce/uploads/2bf7a45451b4abe0c5e9172f5872794e/mass-edit-issues--sidebar.png?

    @iamphill I had @cperessini review, and he gave the :thumbsup: on UX. Can you be more specific about discrepancies you see?

  • @brycepj If the UX have given it a :thumbsup: then i'm all cool!

  • added 1 commit

    • 765d4971 - Make CSS selector related improvements to IssuableBulkUpdateSidebar.

    Compare with previous version

  • added 1 commit

    • 765d4971 - Make CSS selector related improvements to IssuableBulkUpdateSidebar.

    Compare with previous version

  • added 1 commit

    • 92cc75f5 - Refact issuable bulk actions to be a singleton.

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Please register or sign in to reply
    Loading