Move issuable bulk edit form into a sidebar
This MR moves Issue and MR bulk editing into a sidebar.
Some additional changes were made to improve maintainability of the code:
- Standardized naming across filenames, selectors, JS variables etc. to use appropriate variations of 'Issuable bulk update'. There were several different naming conventions describing the same feature including 'bulk edit', 'issues bulk assignment' & 'bulk update'.
- Changed the name of
Issuable
toIssuableIndex
and updated references to it, as it is more accurate and less confusing. - Removed some orphaned bulk update code which had fallen out of use (
app/views/shared/issuable/_filter.html.haml
)
Closes #28340 (closed)
Merge request reports
Activity
added 172 commits
-
6b1912bf...67312fce - 171 commits from branch
master
- 8ce1c020 - Get rough prototype working.
-
6b1912bf...67312fce - 171 commits from branch
added 1 commit
- ea6d0721 - Ensure page content shrinks for right-sidebar.
added 1 commit
- 38c4b43c - Break out sidebar logic into its own class/file.
added 2 commits
added 1 commit
- 534e14e2 - Change bulk edit submit button to Update all
- Resolved by username-removed-408230
added 1 commit
- 2abf823e - Standardize naming on 'bulk-update' and variants'.
added 1 commit
- b66b79c4 - Standardize naming on 'bulk-update' and variants'.
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
added 1 commit
- 94a8580f - Abstract out bulk edit state change logic into toggle methods.
added 1 commit
- 1e184757 - Improve dependency chain and fix issuable_ids hidden field missing.
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
added 1 commit
- e4b71824 - Move bulk update sidebar out of search bar and up a level.
- Resolved by username-removed-408230
added 1 commit
- 6dd85594 - Fix dropdown is-default styles and fix dropdown toggles.
- Resolved by username-removed-408230
@cperessini I still need to get the code reviewed and the build passing, but can you check out this branch and review the UX?
Edited by username-removed-408230
- Resolved by username-removed-408230
added Deliverable frontend labels
changed milestone to %9.3
- Resolved by username-removed-408230
- Resolved by username-removed-408230
added 1 commit
- 259b7556 - Fixup specs and code to eliminate noisy failures.
added 2 commits
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
added 1 commit
- d8b2cdd6 - Fix ref to static method, and shush eslint some more.
- Resolved by username-removed-408230
- Resolved by username-removed-408230
@iamphill I thought you'd be the right person to have review this -- do you mind? Btw, I made some notes in the MR description that might help orient you
assigned to @iamphill
added 1 commit
- 9537e224 - Fix up update issues and merge requests specs.
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
- Resolved by username-removed-408230
assigned to @brycepj
Based on your gif, it also doesn't match the designs https://gitlab.com/gitlab-org/gitlab-ce/uploads/2bf7a45451b4abe0c5e9172f5872794e/mass-edit-issues--sidebar.png?
Based on your gif, it also doesn't match the designs https://gitlab.com/gitlab-org/gitlab-ce/uploads/2bf7a45451b4abe0c5e9172f5872794e/mass-edit-issues--sidebar.png?
@iamphill I had @cperessini review, and he gave the
on UX. Can you be more specific about discrepancies you see?@brycepj If the UX have given it a
then i'm all cool!added 1 commit
- 765d4971 - Make CSS selector related improvements to IssuableBulkUpdateSidebar.
added 1 commit
- 765d4971 - Make CSS selector related improvements to IssuableBulkUpdateSidebar.
added 1 commit
- 92cc75f5 - Refact issuable bulk actions to be a singleton.