Style people in issuable search bar

What does this MR do?

Use display names and avatars instead of usernames for author and assignee in issuable search bar.

Screenshots

Before

After

What are the relevant issue numbers?

closes #30468 (closed)

mentioned in merge request !11404 (merged)

requires !11404 (merged)

added blocked label

added 88 commits

• 56e1d9ec...9fde881d - 86 commits from branch master
• f3b1452c - mock !11404 (merged)
• f896a52d - Simplify filtered_search_visual_tokens_spec.js

Compare with previous version

mentioned in commit 691a98da

added 1 commit

• 691a98da - Style people in issuable search bar (!11402 (merged))

Compare with previous version

mentioned in commit ca8c445f

added 1 commit

• ca8c445f - Style people in issuable search bar (!11402 (merged))

Compare with previous version

mentioned in commit 3c43de28

added 2 commits

• cfd6904b - Simplify filtered_search_visual_tokens_spec.js
• 3c43de28 - Style people in issuable search bar (!11402 (merged))

Compare with previous version

mentioned in commit 068a8d69

added 3 commits

• a849a4b4 - mock !11404 (merged)
• cea4a321 - Simplify filtered_search_visual_tokens_spec.js
• 068a8d69 - Style people in issuable search bar (!11402 (merged))

Compare with previous version

added 4 commits

• 348e1e96 - mock !11404 (merged)
• 0d84613e - Simplify filtered_search_visual_tokens_spec.js
• 73cd0eb6 - Add frontend fixture for issue list
• 1d6e15ff - Style people in issuable search bar (!11402 (merged))

Compare with previous version

changed the description

There is currently a problem that the x gets pushed out of the value-container when there are too many tokens:

I'm not sure how to solve this yet.

@cperessini Related to my problem above: Is the search bar intended to be scrollable?

@winh yeah, currently it's supposed to scroll. We have a proposal to make it wrap instead of scroll, but apparently that's not easy to accomplish #29150 (moved).

Is there a specific behavior that would make your life easier?

added 1 commit

• dfca53e4 - Style people in issuable search bar (!11402 (merged))

Compare with previous version

removed blocked label

resolved all discussions

added 334 commits

• dfca53e4...b00c268b - 331 commits from branch master
• 65ab240d - Simplify filtered_search_visual_tokens_spec.js
• 58ba78ee - Add frontend fixture for issue list
• 50a1b9c7 - Style people in issuable search bar (!11402 (merged))

Compare with previous version

added 1 commit

• 379fc30f - Style people in issuable search bar (!11402 (merged))

Compare with previous version

added 1 commit

• 630ada02 - Style people in issuable search bar (!11402 (merged))

Compare with previous version

added 1 commit

• 630ada02 - Style people in issuable search bar (!11402 (merged))

Compare with previous version

@timzallmann It looks like tests are failing because of the vertical scrolling in the search bar. My workarounds (shortening the text) didn't work. I think, !11633 (closed) would solve the problem. Does it make sense to you that I work on that one first?

added 1 commit

• 3d29061c - Make issuable search bar wrap (!11633 (closed))

Compare with previous version

added 2 commits

• 4d1a1e8c - Style people in issuable search bar (!11402 (merged))
• 9e3db40f - Move clear search button out of issuable search bar

Compare with previous version

resolved all discussions

spec/features/issues/filtered_search/visual_tokens_spec.rb is a legitimate failure. Double clicking on an author token currently doesn't work.

added 2 commits

• 7dfa54a1 - Move clear search button out of issuable search bar
• 76424729 - Style people in issuable search bar (!11402 (merged))

Compare with previous version

added 1 commit

• 7a448e9d - Style people in issuable search bar (!11402 (merged))

Compare with previous version

resolved all discussions

added 1 commit

• 1ae7ef74 - Style people in issuable search bar (!11402 (merged))

Compare with previous version

@timzallmann Can you please review?

assigned to @timzallmann

unmarked as a Work In Progress

resolved all discussions

added 1 commit

• dfc850ca - Style people in issuable search bar (!11402 (merged))

Compare with previous version

added 689 commits

• dfc850ca...68112433 - 685 commits from branch master
• 67e5235e - Simplify filtered_search_visual_tokens_spec.js
• b2297064 - Add frontend fixture for issue list
• f032731e - Move clear search button out of issuable search bar
• 8ac3e3c6 - Style people in issuable search bar (!11402 (merged))

Compare with previous version

added 1 commit

• 46d9da54 - Style people in issuable search bar (!11402 (merged))

Compare with previous version

https://gitlab.com/gitlab-org/gitlab-ce/builds/17761227 ← WaitForAjax module has been removed.

mentioned in commit 0583916d

added 1 commit

• 0583916d - Style people in issuable search bar (!11402 (merged))

Compare with previous version

resolved all discussions

@winh Looks good to me !

approved this merge request

enabled an automatic merge when the pipeline for 0583916d succeeds

merged

mentioned in commit 51c19616

mentioned in issue #34013 (moved)

mentioned in issue #34285 (closed)