Skip to content
Snippets Groups Projects

Don’t create comment on JIRA if link already exists

Merged Jarka Kadlecova requested to merge 25373-jira-links into master
All threads resolved!

What does this MR do?

When a JIRA issue is mentioned on a merge request or commit a link and comment is created on the JIRA issue. When title or description changes jira_service only updates the link (so that the title of that link is up to date) but does not create a new comment.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

When we had an MR or a commit with JIRA issue link in the description / title and the title was changed or the description was changed by a new user a new link and comment were created. That is not expected behaviour. We don't want a new comment and link for every change.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #25373 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Great merge request @jarka. I just left a minor comment =)

  • assigned to @jarka

  • Jarka Kadlecova resolved all discussions

    resolved all discussions

  • Author Maintainer

    Thanks @felipe_artur . I changed it as you suggested

  • @jarka Looks good thanks =)

  • assigned to @jarka

  • assigned to @rymai

  • @jarka Thanks, I had a few comments.

  • changed milestone to %9.3

  • Jarka Kadlecova resolved all discussions

    resolved all discussions

  • Jarka Kadlecova added 859 commits

    added 859 commits

    • 8d8a3e59...52a3d437 - 858 commits from branch master
    • ab8d54b2 - Don’t create comment on JIRA if link already exists

    Compare with previous version

  • Jarka Kadlecova added 859 commits

    added 859 commits

    • 8d8a3e59...52a3d437 - 858 commits from branch master
    • ab8d54b2 - Don’t create comment on JIRA if link already exists

    Compare with previous version

  • Jarka Kadlecova
  • Author Maintainer

    Thanks for the review @rymai - I addressed your comments

  • Jarka Kadlecova added 859 commits

    added 859 commits

    • 8d8a3e59...52a3d437 - 858 commits from branch master
    • ab8d54b2 - Don’t create comment on JIRA if link already exists

    Compare with previous version

  • assigned to @rymai

  • username-removed-128633 resolved all discussions

    resolved all discussions

  • @jarka Thanks, looks good to me! :heart:

  • username-removed-128633 approved this merge request

    approved this merge request

  • username-removed-128633 enabled an automatic merge when the pipeline for ab8d54b2 succeeds

    enabled an automatic merge when the pipeline for ab8d54b2 succeeds

  • mentioned in commit 374486fb

  • Please register or sign in to reply
    Loading