Resolve "TypeError: Unable to get property 'form' of undefined or null reference"

What does this MR do?

Fixes: https://sentry.gitlap.com/gitlab/gitlabcom-clientside/issues/30927/

This error occurs when an issues#index or similar shows an empty state and we're always expecting a filtered-search box, so this will error if the filtered_search box isn't available. Non critical bug.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes #32532 (moved)

added 1 commit

• 9ba83011 - Check for a filteredsearch before instantiating because constructor queries

Compare with previous version

@ClemMakesApps wanna review?

assigned to @ClemMakesApps

unmarked as a Work In Progress

@lbennett can you fill out the MR description? Not really sure what we are trying to achieve here

assigned to @lbennett

changed the description

added ~12980 frontend labels

changed milestone to %9.3

Sorry @ClemMakesApps, any better?

assigned to @ClemMakesApps

changed milestone to %9.2

@lbennett can we also add tests to this so that we don't recreate this again?

assigned to @lbennett

@ClemMakesApps Sure! I can do the dispatcher one, but one of these is an inline script

Just test the dispatcher then

@ClemMakesApps I'm going to finish this dispatcher spec tomorrow, sorry :( Another one of those tricky constructors

Sounds good to me! You could also do an integrated spec and just test the generated fixtures if you want, but whatever is easiest for you

This test is hillariously impossible.

I also think even generating a static fixture for it could be tough too. I'm determined to finish it though! Just pray for me!

I've just realised, we don't have an empty state spec for this, I'll just add that. If an exception is throw, feature specs fail.

added 3 commits

• 15d78e28 - Added specs
• 207da170 - Remove disaptcher unit test
• d7b88d77 - Add empty state test

Compare with previous version

added 3 commits

• 15d78e28 - Added specs
• 207da170 - Remove disaptcher unit test
• d7b88d77 - Add empty state test

Compare with previous version

assigned to @ClemMakesApps

assigned to @lbennett

changed milestone to %9.3

closed

assigned to @ClemMakesApps

reopened

assigned to @lbennett

closed

resolved all discussions

reopened

added 2307 commits

• d7b88d77...ce0c5da0 - 2303 commits from branch master
• ca3e17be - Check for a filteredsearch before instantiating because constructor queries
• f3003e7d - Added specs
• 6c16a700 - Remove disaptcher unit test
• 46918a7d - Add empty state test

Compare with previous version

assigned to @ClemMakesApps

This test passes on master. Seems like we have to set JS true? That could continue to degrade our tests though..

Just thinking out loud here. What if we extracted that inline javascript into a javascript file and then include it using script tags so that we can test this using karma?

Ahh yes. Well, you can enable js for this single scenario, so it wont degrade the whole spec.

Tried this again in master and it still passed

Hrm...

assigned to @lbennett

added 1 commit

• 1b2b186e - Update list_spec.rb to enable js to test for js exceptions

Compare with previous version

resolved all discussions

resolved all discussions

assigned to @ClemMakesApps

assigned to @lbennett

changed milestone to %9.5

removed assignee