Skip to content
Snippets Groups Projects

Fix clicking disabled clipboard button toolip

Merged Luke "Jared" Bennett requested to merge disable-clicking-disabled-clipboard-button into master
All threads resolved!

What does this MR do?

Use anchor instead of button to avoid bootstrap tooltip tripping up on disabled buttons.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)2017-05-18_16.44.41

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/32518

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Luke "Jared" Bennett resolved all discussions

    resolved all discussions

  • added 1 commit

    • be411be7 - Correct fix by reverting to anchor and bluring the disabled button on click

    Compare with previous version

  • added 1 commit

    • 255aed3a - Added spec for bluring disabled copy button

    Compare with previous version

  • Phil Hughes approved this merge request

    approved this merge request

  • merged

  • Phil Hughes mentioned in commit 6b092d96

    mentioned in commit 6b092d96

  • Picked into 9-2-stable, will go into 9.2.0-rc7.

  • Phil Hughes mentioned in commit af81730b

    mentioned in commit af81730b

  • Please register or sign in to reply
    Loading