Skip to content
Snippets Groups Projects

Fix ProjectCacheWorker for plain READMEs

Merged Toon Claes requested to merge tc-fix-broken-plain-readme into master
All threads resolved!

What does this MR do?

The ProjectCacheWorker refreshes cache periodically, but it runs outside Rails context. So include the ActionView helpers so the content_tag method is available.

Are there points in the code the reviewer needs to double check?

I added include ActionView::Context because, I ran into this error:

NoMethodError: undefined method 'output_buffer=' for

See http://stackoverflow.com/a/7562194/89376

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Fixes gitlab-org/gitlab-ce#32540

Edited by Toon Claes

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @to1ne

  • Douwe Maan approved this merge request

    approved this merge request

  • Douwe Maan added ~149423 and removed Next Patch Release labels

    added ~149423 and removed Next Patch Release labels

  • Douwe Maan resolved all discussions

    resolved all discussions

  • Douwe Maan mentioned in commit a3eabcc2

    mentioned in commit a3eabcc2

  • merged

  • Douwe Maan mentioned in commit d3cc3516

    mentioned in commit d3cc3516

  • Picked into 9-2-stable, will go into 9.2.0-rc7.

  • Please register or sign in to reply
    Loading